feat(quarterly-connection): add refinement workflow and prepare for initial release#421
Open
jaypoulz wants to merge 1 commit intoopenshift-eng:mainfrom
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaypoulz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Plugin as QuarterlyConnection
participant GH as GitHub API
participant Jira as Jira API
participant GDrive as Google Drive
participant Mail as Email Store
participant Slack as Slack Archive
participant Aggregator
participant Formatter
participant FS as Filesystem (.work/outputs)
User->>Plugin: invoke /quarterly-connection:build [role] [start-date] [end-date]
Plugin->>GH: query merged PRs (auth)
Plugin->>Jira: query issues (optional auth)
Plugin->>GDrive: list/read docs (prompt for public links)
Plugin->>Mail: read .eml inputs
Plugin->>Slack: read exported messages/files
GH-->>Aggregator: return PRs
Jira-->>Aggregator: return issues
GDrive-->>Aggregator: return docs
Mail-->>Aggregator: return emails
Slack-->>Aggregator: return messages
Aggregator->>Plugin: deduplicate, associate PRs↔Jira, validate links
Plugin->>Formatter: apply dense-bullet rules, map to v10.6 competencies
Formatter->>FS: write Workday-ready HTML, Markdown, analysis.md
Plugin->>User: output paths and report summary
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (3)
plugins/quarterly-connection/reference/red-hat-competencies.md (1)
37-39: Add a language tag to the fenced pattern block.This block is missing a fence language and triggers MD040 in markdownlint.
Proposed fix
-``` +```text [Action verb] [deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact], [how/details].</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@plugins/quarterly-connection/reference/red-hat-competencies.mdaround lines
37 - 39, The fenced code block containing the pattern "[Action verb]
[deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact],
[how/details]." is missing a language tag and triggers markdownlint MD040;
update that fenced block (the triple-backtick block with that pattern) to
include a language identifier such as "text" (e.g., ```text) so the block is
explicitly language-tagged and the MD040 warning is resolved.</details> </blockquote></details> <details> <summary>plugins/quarterly-connection/commands/build.md (1)</summary><blockquote> `42-42`: **Add language tags to fenced code blocks (MD040).** Multiple fenced blocks are missing language identifiers and will keep markdownlint warnings active. Also applies to: 94-94, 191-191, 250-250, 284-284, 403-403, 457-457, 488-488, 521-521, 601-601, 606-606, 611-611, 616-616, 621-621, 768-768, 846-846, 851-851, 856-856 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@plugins/quarterly-connection/commands/build.mdat line 42, Multiple fenced
code blocks in plugins/quarterly-connection/commands/build.md are missing
language identifiers which triggers markdownlint MD040; edit each fenced block
(the triple-backtick sections mentioned in the comment) and add the appropriate
language tag (for examplebash orsh for shell commands,json for JSON,yaml for YAML,js orts for JavaScript/TypeScript, etc.) to the openingplugins/quarterly-connection/README.md (1)
14-16: Add language identifiers to fenced code blocks to satisfy markdownlint.Several fenced blocks are missing language tags (MD040), which will keep lint warnings noisy in CI.
Also applies to: 19-21, 91-129, 141-148, 184-205
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/README.md` around lines 14 - 16, The README has multiple fenced code blocks without language identifiers causing markdownlint MD040 warnings; edit plugins/quarterly-connection/README.md and add appropriate language tags (e.g., bash, sh, json, yaml) to each fenced block — including the example block containing "/quarterly-connection:build [role] [start-date] [end-date]" and the other blocks at ranges 19-21, 91-129, 141-148, and 184-205 — so each triple-backtick fence becomes e.g., ```bash or ```json as appropriate for the block content.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/data.json`:
- Around line 1719-1723: The JSON entry for the command with "name": "build" has
an empty "synopsis" which hurts discoverability; update the "synopsis" field for
that object (the entry with "name": "build" and "argument_hint": "[role]
[start-date] [end-date]") to a short usage summary such as "build [role]
[start-date] [end-date] — generate quarterly accomplishment summaries for a
given role and date range" so generated docs/UIs show a concise one-line usage
and purpose.
In `@plugins/quarterly-connection/commands/build.md`:
- Line 73: Update the documentation line that currently references
"inputs/additional.txt" to use the directory form "inputs/additional/" so it
matches the rest of the document and the parser steps; replace the literal
"inputs/additional.txt" with "inputs/additional/" wherever it appears in the
build.md content to avoid mismatched input handling.
- Around line 639-641: The Markdown links in build.md use repo-root-relative
paths that break when rendered from plugins/quarterly-connection/commands/ (e.g.
the strings plugins/quarterly-connection/reference/red-hat-competencies.md and
plugins/quarterly-connection/reference/example-bullets.md); update them to valid
paths by either prefixing with a leading slash to make them repo-root-relative
(/plugins/quarterly-connection/reference/...) or by using correct relative paths
from the commands/ directory (../reference/red-hat-competencies.md and
../reference/example-bullets.md) so the links resolve correctly.
- Line 67: Update the role validation list in the "Validate role parameter"
section to match the v10.6 role set used elsewhere (the README and Line 146
reference) by removing legacy roles SSE2, PSE2, DSSE, DPSE, Senior Staff,
Distinguished and adding SE so the list exactly contains the seven valid roles;
ensure the text under "Validate role parameter" and any other occurrences in
build.md that enumerate roles are made identical to the v10.6 canonical list to
avoid contradictory instructions.
- Around line 606-633: The examples and Key Improvements use deprecated
competency phrases ("cross-functional collaboration", "forward planning",
"technical innovation", "team enablement"); update every occurrence in the
example block and Key Improvements to the v10.6-approved competency keywords
(replace those exact quoted phrases in the "After" examples and the Additional
Examples entries), ensure the example PR/issue lines remain unchanged, and
remove any remaining deprecated keywords from the bullet list so all examples
only reference the new v10.6 competency terms.
In `@plugins/quarterly-connection/README.md`:
- Around line 297-299: The README's internal links are written as if at repo
root and thus break; update the three links so they are relative to
plugins/quarterly-connection/README.md (e.g., change
`plugins/quarterly-connection/reference/red-hat-competencies.md` to
`./reference/red-hat-competencies.md`,
`plugins/quarterly-connection/reference/example-bullets.md` to
`./reference/example-bullets.md`, and
`plugins/quarterly-connection/commands/build.md` to `./commands/build.md`) so
they resolve correctly from the README's location.
---
Nitpick comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Line 42: Multiple fenced code blocks in
plugins/quarterly-connection/commands/build.md are missing language identifiers
which triggers markdownlint MD040; edit each fenced block (the triple-backtick
sections mentioned in the comment) and add the appropriate language tag (for
example ```bash or ```sh for shell commands, ```json for JSON, ```yaml for YAML,
```js or ```ts for JavaScript/TypeScript, etc.) to the opening ``` so each code
fence has a language hint and the MD040 warnings are resolved.
In `@plugins/quarterly-connection/README.md`:
- Around line 14-16: The README has multiple fenced code blocks without language
identifiers causing markdownlint MD040 warnings; edit
plugins/quarterly-connection/README.md and add appropriate language tags (e.g.,
bash, sh, json, yaml) to each fenced block — including the example block
containing "/quarterly-connection:build [role] [start-date] [end-date]" and the
other blocks at ranges 19-21, 91-129, 141-148, and 184-205 — so each
triple-backtick fence becomes e.g., ```bash or ```json as appropriate for the
block content.
In `@plugins/quarterly-connection/reference/red-hat-competencies.md`:
- Around line 37-39: The fenced code block containing the pattern "[Action verb]
[deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact],
[how/details]." is missing a language tag and triggers markdownlint MD040;
update that fenced block (the triple-backtick block with that pattern) to
include a language identifier such as "text" (e.g., ```text) so the block is
explicitly language-tagged and the MD040 warning is resolved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fdf9ed87-de2d-4c69-9659-ede21f039ceb
📒 Files selected for processing (8)
.claude-plugin/marketplace.jsonPLUGINS.mddocs/data.jsonplugins/quarterly-connection/.claude-plugin/plugin.jsonplugins/quarterly-connection/README.mdplugins/quarterly-connection/commands/build.mdplugins/quarterly-connection/reference/example-bullets.mdplugins/quarterly-connection/reference/red-hat-competencies.md
Comment on lines
+639
to
+641
| **Full Reference:** See `plugins/quarterly-connection/reference/red-hat-competencies.md` | ||
|
|
||
| **Example Bullets:** See `plugins/quarterly-connection/reference/example-bullets.md` |
Contributor
There was a problem hiding this comment.
Reference paths are broken from the commands/ directory.
These paths are written as repo-root-relative strings, but in Markdown they resolve relative to plugins/quarterly-connection/commands/, so links will break.
Proposed fix
-**Full Reference:** See `plugins/quarterly-connection/reference/red-hat-competencies.md`
-
-**Example Bullets:** See `plugins/quarterly-connection/reference/example-bullets.md`
+**Full Reference:** See `../reference/red-hat-competencies.md`
+
+**Example Bullets:** See `../reference/example-bullets.md`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/quarterly-connection/commands/build.md` around lines 639 - 641, The
Markdown links in build.md use repo-root-relative paths that break when rendered
from plugins/quarterly-connection/commands/ (e.g. the strings
plugins/quarterly-connection/reference/red-hat-competencies.md and
plugins/quarterly-connection/reference/example-bullets.md); update them to valid
paths by either prefixing with a leading slash to make them repo-root-relative
(/plugins/quarterly-connection/reference/...) or by using correct relative paths
from the commands/ directory (../reference/red-hat-competencies.md and
../reference/example-bullets.md) so the links resolve correctly.
jaypoulz
force-pushed
the
feature/format-accomplishments-modern
branch
2 times, most recently
from
9eded30 to
0c06c41
Compare
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (3)
plugins/quarterly-connection/commands/build.md (3)
73-73:⚠️ Potential issue | 🟠 MajorInput path conflicts with directory structure.
Line 73 references
inputs/additional.txt(a single file), but the rest of the documentation consistently usesinputs/additional/as a directory (Lines 52, 241, 308, 831-834). This inconsistency would confuse users about where to place additional accomplishments.🔧 Proposed fix
- - Additional: Write freeform items to `inputs/additional.txt` + - Additional: Write freeform items as .txt or .md files to `inputs/additional/`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/commands/build.md` at line 73, The doc contains an inconsistent input path: change the reference to the single file "inputs/additional.txt" to the directory form "inputs/additional/" so it matches the rest of the documentation (references to inputs/additional/); update the text at the location that currently mentions inputs/additional.txt to instruct users to write freeform items into the inputs/additional/ directory instead.
67-67:⚠️ Potential issue | 🟠 MajorRole validation list still inconsistent with v10.6 framework.
Line 67 lists legacy role names that don't match the canonical v10.6 role set defined at Line 146 and Lines 864-871. The current list includes outdated roles (
SSE2,PSE2,DSSE,DPSE,Senior Staff,Distinguished) and omitsSE.This will cause validation errors and contradictory behavior.
🔧 Proposed fix
-1. **Validate role parameter** - Must be one of: SSE, PSE, SSE2, PSE2, DSSE, DPSE, Staff, Senior Staff, Distinguished +1. **Validate role parameter** - Must be one of: SE, SSE, PSE, SPSE, Staff, DE, SDE🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/commands/build.md` at line 67, The role validation list at the top of the doc contains legacy role names and is inconsistent with the canonical v10.6 role set; update the validation text to exactly match the canonical v10.6 roles (include "SE", remove "SSE2", "PSE2", "DSSE", "DPSE", "Senior Staff", "Distinguished") so the validation list and the canonical set referenced elsewhere are identical; locate the role list text in build.md (the "Validate role parameter" bullet) and replace its entries with the exact canonical v10.6 names used elsewhere in the document to eliminate the mismatch.
606-633:⚠️ Potential issue | 🟠 MajorExamples still use deprecated v9.0 competency keywords.
The "After" examples and "Key Improvements" section (Lines 606-633) continue to use outdated v9.0 terminology instead of v10.6 keywords:
- Line 607: "cross-functional collaboration and forward planning"
- Line 617: "technical innovation and business impact"
- Line 622: "technical knowledge"
- Line 624: "technical innovation and team enablement"
- Line 626: "continuous improvement and product delivery lifecycle management"
- Line 628: "functional area leadership and cross-functional collaboration"
- Line 632: Lists these as if they're valid keywords
These should use v10.6 keywords as defined in the competency reference files.
🔧 Proposed fixes (example replacements)
-Developed service health API specification [[PR#123](https://github.com/org/api-repo/pull/123)] via cross-functional collaboration and forward planning to enable automated health monitoring in production, working with platform team. +Developed service health API specification [[PR#123](https://github.com/org/api-repo/pull/123)] via Internal and External Collaboration and System Design to enable automated health monitoring in production, working with platform team. -Fixed service startup [[PR#456](https://github.com/org/backend-service/pull/456)] via technical innovation and business impact to prevent false degraded states, implementing exponential backoff to retry initialization for 10 minutes before degrading. +Fixed service startup [[PR#456](https://github.com/org/backend-service/pull/456)] via Apply and Advance Technical Practices and Technical Acumen to prevent false degraded states, implementing exponential backoff to retry initialization for 10 minutes before degrading.Apply similar updates to all examples in Lines 620-628 and the keyword list at Line 632.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/commands/build.md` around lines 606 - 633, Update the deprecated v9.0 competency phrases used in the "After" examples and the "Key Improvements" list by replacing occurrences like "cross-functional collaboration and forward planning", "technical innovation and business impact", "technical knowledge", "technical innovation and team enablement", "continuous improvement and product delivery lifecycle management", and "functional area leadership and cross-functional collaboration" with their v10.6 equivalents from the competency reference; modify the example lines (the "After" block and the Additional Examples block) and the keyword list so each example uses the proper v10.6 keyword terms, verify consistency across all examples in that section, and consult the competency reference files to ensure exact v10.6 phrasing is used for each replaced keyword.
🧹 Nitpick comments (4)
plugins/quarterly-connection/reference/red-hat-competencies.md (2)
178-178: Consider hyphenating "industry recognized" for formal style.The phrase "industry recognized expert" would be more formally correct as "industry-recognized expert" when used as a compound adjective modifying "expert".
📝 Proposed fix
-- **Skill level:** Industry recognized expert, creates next-gen test automation +- **Skill level:** Industry-recognized expert, creates next-gen test automation🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/reference/red-hat-competencies.md` at line 178, Change the compound adjective "industry recognized expert" to "industry-recognized expert" in the competency text (the line containing "**Skill level:** Industry recognized expert, creates next-gen test automation") so the phrase is hyphenated correctly when modifying "expert".
37-39: Consider adding language identifier to fenced code block.The code block showing the pattern format would benefit from a language identifier for better rendering and syntax highlighting. While the content is clear, adding
textor similar would satisfy linting rules.📝 Proposed fix
**Pattern:** -``` +```text [Action verb] [deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact], [how/details].</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@plugins/quarterly-connection/reference/red-hat-competencies.mdaround lines
37 - 39, The fenced code block showing the pattern currently uses triple
backticks with no language; update that block to include a language identifier
(e.g., changetotext) so the snippet renders and satisfies
linting/syntax-highlighting rules for the pattern line "[Action verb]
[deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact],
[how/details]."</details> </blockquote></details> <details> <summary>plugins/quarterly-connection/commands/build.md (1)</summary><blockquote> `42-58`: **Consider adding language identifiers to fenced code blocks.** Multiple code blocks throughout the file lack language identifiers, which would improve rendering and satisfy linting rules. While the content is clear, adding appropriate identifiers (`text`, `bash`, `shell`, `html`, etc.) would be a minor improvement. This is a low-priority style improvement flagged by markdownlint. The blocks are already functional and clear. Also applies to: 94-96, 191-196, 250-253, 284-296, 403-411, 457-463, 488-501, 521-530, 601-603, 768-772, 846-848, 851-853, 856-860 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@plugins/quarterly-connection/commands/build.mdaround lines 42 - 58, The
fenced code blocks in plugins/quarterly-connection/commands/build.md are missing
language identifiers (e.g., the directory tree and other snippet blocks); update
each triple-backtick block (including the one showing the
.work/quarterly-connection/ tree and the other blocks noted in the review) to
include an appropriate language tag such as text, bash, shell, or html so
markdownlint passes and rendering improves—search for the triple-backtick
markers in build.md and add the correct language identifier after the openingplugins/quarterly-connection/reference/example-bullets.md (1)
7-9: Consider adding language identifiers to fenced code blocks.Multiple code blocks throughout the file lack language identifiers, which would improve rendering and satisfy linting rules. While the examples are clear, adding identifiers (such as
textormarkdown) would be a minor improvement.This is a low-priority style improvement flagged by markdownlint. The examples are already clear and functional.
Also applies to: 16-18, 28-30, 40-42, 50-52, 60-62, 71-73, 81-83, 95-97, 106-108, 111-113, 122-124, 127-129, 137-139, 142-144, 151-153
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/reference/example-bullets.md` around lines 7 - 9, Update every fenced code block that contains the bullet template "[Action verb] [deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact], [how/details]." (and the other similar example blocks) to include a language identifier (e.g., ```text or ```markdown) immediately after the opening backticks so markdownlint renders them correctly and the linter passes; make this change for all example blocks throughout the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Line 73: The doc contains an inconsistent input path: change the reference to
the single file "inputs/additional.txt" to the directory form
"inputs/additional/" so it matches the rest of the documentation (references to
inputs/additional/); update the text at the location that currently mentions
inputs/additional.txt to instruct users to write freeform items into the
inputs/additional/ directory instead.
- Line 67: The role validation list at the top of the doc contains legacy role
names and is inconsistent with the canonical v10.6 role set; update the
validation text to exactly match the canonical v10.6 roles (include "SE", remove
"SSE2", "PSE2", "DSSE", "DPSE", "Senior Staff", "Distinguished") so the
validation list and the canonical set referenced elsewhere are identical; locate
the role list text in build.md (the "Validate role parameter" bullet) and
replace its entries with the exact canonical v10.6 names used elsewhere in the
document to eliminate the mismatch.
- Around line 606-633: Update the deprecated v9.0 competency phrases used in the
"After" examples and the "Key Improvements" list by replacing occurrences like
"cross-functional collaboration and forward planning", "technical innovation and
business impact", "technical knowledge", "technical innovation and team
enablement", "continuous improvement and product delivery lifecycle management",
and "functional area leadership and cross-functional collaboration" with their
v10.6 equivalents from the competency reference; modify the example lines (the
"After" block and the Additional Examples block) and the keyword list so each
example uses the proper v10.6 keyword terms, verify consistency across all
examples in that section, and consult the competency reference files to ensure
exact v10.6 phrasing is used for each replaced keyword.
---
Nitpick comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Around line 42-58: The fenced code blocks in
plugins/quarterly-connection/commands/build.md are missing language identifiers
(e.g., the directory tree and other snippet blocks); update each triple-backtick
block (including the one showing the .work/quarterly-connection/ tree and the
other blocks noted in the review) to include an appropriate language tag such as
text, bash, shell, or html so markdownlint passes and rendering improves—search
for the triple-backtick markers in build.md and add the correct language
identifier after the opening ``` for each block.
In `@plugins/quarterly-connection/reference/example-bullets.md`:
- Around line 7-9: Update every fenced code block that contains the bullet
template "[Action verb] [deliverable] [readable links] via [RESPONSIBILITY] and
[SKILL] to [impact], [how/details]." (and the other similar example blocks) to
include a language identifier (e.g., ```text or ```markdown) immediately after
the opening backticks so markdownlint renders them correctly and the linter
passes; make this change for all example blocks throughout the file.
In `@plugins/quarterly-connection/reference/red-hat-competencies.md`:
- Line 178: Change the compound adjective "industry recognized expert" to
"industry-recognized expert" in the competency text (the line containing
"**Skill level:** Industry recognized expert, creates next-gen test automation")
so the phrase is hyphenated correctly when modifying "expert".
- Around line 37-39: The fenced code block showing the pattern currently uses
triple backticks with no language; update that block to include a language
identifier (e.g., change ``` to ```text) so the snippet renders and satisfies
linting/syntax-highlighting rules for the pattern line "[Action verb]
[deliverable] [readable links] via [RESPONSIBILITY] and [SKILL] to [impact],
[how/details]."
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 164a4d10-23cd-4404-b604-7072f5678d9c
📒 Files selected for processing (8)
.claude-plugin/marketplace.jsonPLUGINS.mddocs/data.jsonplugins/quarterly-connection/.claude-plugin/plugin.jsonplugins/quarterly-connection/README.mdplugins/quarterly-connection/commands/build.mdplugins/quarterly-connection/reference/example-bullets.mdplugins/quarterly-connection/reference/red-hat-competencies.md
✅ Files skipped from review due to trivial changes (5)
- plugins/quarterly-connection/.claude-plugin/plugin.json
- PLUGINS.md
- .claude-plugin/marketplace.json
- plugins/quarterly-connection/README.md
- docs/data.json
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
plugins/quarterly-connection/commands/build.md (1)
67-67:⚠️ Potential issue | 🟠 MajorRole validation remains internally inconsistent with the declared canonical role count.
This file repeatedly defines the accepted role set as “exactly 6,” which conflicts with the broader plugin docs/objective language that describe 7 canonical roles. Align all role enumerations and role-count text to one source of truth.
Also applies to: 146-147, 864-870
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/commands/build.md` at line 67, The "Validate role parameter" section currently lists exactly 6 roles ("SE, SSE, PSE, SPSE, DE, SDE") which conflicts with the plugin's canonical 7-role definition; update every role enumeration and the accompanying "exactly 6" count to match the canonical 7-role set from the plugin docs/objective (replace the 6-role list string and count in the "Validate role parameter" block and the other occurrences that mirror it at the other locations), ensuring the text and list (e.g., the current "SE, SSE, PSE, SPSE, DE, SDE" tokens) are replaced with the authoritative 7-role tokens and the numeric count is adjusted accordingly so all mentions are consistent.
🧹 Nitpick comments (1)
plugins/quarterly-connection/commands/build.md (1)
191-196: Add language identifiers to fenced code blocks to satisfy markdownlint MD040.Multiple fenced blocks are missing explicit language tags, which will keep lint warnings noisy and reduce renderer/tooling consistency.
Example pattern
-``` +```text Extracted from GitHub PRs: PROJ-123 (from PR#100) - Qualified: Resolved 2026-03-15 ... -``` +```Also applies to: 250-252, 284-296, 403-410, 457-463, 488-501, 521-530, 768-772, 846-860
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/commands/build.md` around lines 191 - 196, Fenced code blocks in commands/build.md are missing language identifiers (triggering markdownlint MD040); update each plain-text fence to include a language tag (e.g., use ```text for the PR extraction snippets) so renderers and linters stop warning. Specifically, edit the fenced blocks shown in the diff/example and the other affected ranges (250-252, 284-296, 403-410, 457-463, 488-501, 521-530, 768-772, 846-860) to replace ``` with ```text (or another appropriate language tag) while preserving the block content and surrounding backticks. Ensure consistency across the file so all plain-text code fences use the same language identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/quarterly-connection/README.md`:
- Line 32: The README has inconsistent ordering of data sources: the "Sequential
prompting" bullet (the Jira → GitHub → Google Drive → Email → Slack → Other
order) conflicts with the "Workday Goals" section ordering; pick one canonical
source order (e.g., Jira → GitHub → Google Drive → Email → Slack → Workday Goals
→ Other) and update the "Sequential prompting" line and the "Workday Goals"
lines (the two bullets that currently list Workday first) so both sections
present the exact same sequence and phrasing to avoid confusion.
- Around line 23-30: The README's roles header says "exactly 7" but only lists
six roles for the /quarterly-connection:build contract; fix by making the
contract and list consistent: either add the missing role to the enumerated list
(so the list contains seven distinct entries) or change the header text to
"exactly 6" and update any references to /quarterly-connection:build that assert
a 7-role requirement; ensure the chosen canonical definition is applied
everywhere in the README and any contract text.
In `@plugins/quarterly-connection/reference/red-hat-competencies.md`:
- Line 114: The user-facing guidance contains inconsistent
hyphenation/terminology: replace "Open source contributions, community
maintenance, public engagement" with "Open-source contributions, community
maintenance, public engagement", change "Industry recognized" to
"Industry-recognized", and update "forward planning" used as a compound modifier
to "forward-planning"; search the document for those exact phrases and apply the
hyphenated forms across the file (e.g., the lines containing "Open source",
"Industry recognized", and "forward planning") so all occurrences in the
red-hat-competencies.md content are consistent.
---
Duplicate comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Line 67: The "Validate role parameter" section currently lists exactly 6 roles
("SE, SSE, PSE, SPSE, DE, SDE") which conflicts with the plugin's canonical
7-role definition; update every role enumeration and the accompanying "exactly
6" count to match the canonical 7-role set from the plugin docs/objective
(replace the 6-role list string and count in the "Validate role parameter" block
and the other occurrences that mirror it at the other locations), ensuring the
text and list (e.g., the current "SE, SSE, PSE, SPSE, DE, SDE" tokens) are
replaced with the authoritative 7-role tokens and the numeric count is adjusted
accordingly so all mentions are consistent.
---
Nitpick comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Around line 191-196: Fenced code blocks in commands/build.md are missing
language identifiers (triggering markdownlint MD040); update each plain-text
fence to include a language tag (e.g., use ```text for the PR extraction
snippets) so renderers and linters stop warning. Specifically, edit the fenced
blocks shown in the diff/example and the other affected ranges (250-252,
284-296, 403-410, 457-463, 488-501, 521-530, 768-772, 846-860) to replace ```
with ```text (or another appropriate language tag) while preserving the block
content and surrounding backticks. Ensure consistency across the file so all
plain-text code fences use the same language identifier.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 492caa57-6d16-440c-8a89-f8aad18a5935
📒 Files selected for processing (8)
.claude-plugin/marketplace.jsonPLUGINS.mddocs/data.jsonplugins/quarterly-connection/.claude-plugin/plugin.jsonplugins/quarterly-connection/README.mdplugins/quarterly-connection/commands/build.mdplugins/quarterly-connection/reference/example-bullets.mdplugins/quarterly-connection/reference/red-hat-competencies.md
✅ Files skipped from review due to trivial changes (4)
- plugins/quarterly-connection/.claude-plugin/plugin.json
- .claude-plugin/marketplace.json
- docs/data.json
- plugins/quarterly-connection/reference/example-bullets.md
🚧 Files skipped from review as they are similar to previous changes (1)
- PLUGINS.md
| - `SDE` - Senior Distinguished Engineer | ||
|
|
||
| **Features:** | ||
| - **Sequential prompting:** Guides you through data sources ONE AT A TIME (Jira → GitHub → Google Drive → Email → Slack → Other) |
Contributor
There was a problem hiding this comment.
Keep source-order instructions consistent across sections.
Line 32 lists sequential prompting starting at Jira, while Lines 74–75 define Workday Goals first. Use one canonical order to avoid user error in data collection.
Also applies to: 74-75
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/quarterly-connection/README.md` at line 32, The README has
inconsistent ordering of data sources: the "Sequential prompting" bullet (the
Jira → GitHub → Google Drive → Email → Slack → Other order) conflicts with the
"Workday Goals" section ordering; pick one canonical source order (e.g., Jira →
GitHub → Google Drive → Email → Slack → Workday Goals → Other) and update the
"Sequential prompting" line and the "Workday Goals" lines (the two bullets that
currently list Workday first) so both sections present the exact same sequence
and phrasing to avoid confusion.
| **Responsibility:** Internal and External Collaboration | ||
| **Skill:** Knowledge Sharing | ||
| **Pattern:** "via Internal and External Collaboration and Knowledge Sharing" | ||
| **When:** Open source contributions, community maintenance, public engagement |
Contributor
There was a problem hiding this comment.
Polish terminology/hyphenation in user-facing framework guidance.
A few phrases are grammatically off and may reduce documentation clarity (Line 114 “Open source”, Line 178 “Industry recognized”, Line 231 “forward planning”).
Suggested wording cleanup
-**When:** Open source contributions, community maintenance, public engagement
+**When:** Open-source contributions, community maintenance, public engagement
-- **Skill level:** Industry recognized expert, creates next-gen test automation
+- **Skill level:** Industry-recognized expert, creates next-gen test automation
-| "forward planning" | "Own and Deliver Business Impact and System Design" |
+| "planning" | "Own and Deliver Business Impact and System Design" |Also applies to: 178-178, 231-231
🧰 Tools
🪛 LanguageTool
[uncategorized] ~114-~114: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...ration and Knowledge Sharing" When: Open source contributions, community maintenance, p...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/quarterly-connection/reference/red-hat-competencies.md` at line 114,
The user-facing guidance contains inconsistent hyphenation/terminology: replace
"Open source contributions, community maintenance, public engagement" with
"Open-source contributions, community maintenance, public engagement", change
"Industry recognized" to "Industry-recognized", and update "forward planning"
used as a compound modifier to "forward-planning"; search the document for those
exact phrases and apply the hyphenated forms across the file (e.g., the lines
containing "Open source", "Industry recognized", and "forward planning") so all
occurrences in the red-hat-competencies.md content are consistent.
0c06c41 to
0b9cff1
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
plugins/quarterly-connection/README.md (1)
246-246: Use a portable token path in docs.
/home/claude/.claude/.gh-tokenis machine/user-specific; prefer a home-relative path (for example~/.claude/.gh-token) to keep release docs generic and usable across environments.Proposed doc fix
-**GitHub Token:** Place in `/home/claude/.claude/.gh-token` or configure `gh auth login` +**GitHub Token:** Place in `~/.claude/.gh-token` or configure `gh auth login`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/quarterly-connection/README.md` at line 246, The README currently hardcodes a user-specific path "/home/claude/.claude/.gh-token"; update the docs to use a portable home-relative path (e.g. "~/.claude/.gh-token" or mention "$HOME/.claude/.gh-token") wherever that string appears (see the "**GitHub Token:** Place in ..." line in README.md) and keep the existing alternative suggestion to use "gh auth login" so the instruction is generic across environments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/quarterly-connection/commands/build.md`:
- Around line 758-760: The docs currently state "You save documents as .txt or
.md files" but elsewhere documents `.eml` support; update every occurrence of
that sentence and any other places that list supported file formats so they
consistently mention ".txt, .md, and .eml" (or "text, markdown, and .eml email
files") and ensure the surrounding workflow steps that reference
source-links.txt and the formatted-bullets step still match the updated wording;
search for the exact phrase "You save documents as .txt or .md files", mentions
of ".eml", and references to `source-links.txt` and replace or harmonize the
wording so all sections present the same supported formats.
- Line 10: Several fenced code blocks in the markdown lack language tags causing
markdownlint MD040 failures; update each triple-backtick fence to include an
appropriate language identifier (e.g., change ``` to ```text, ```bash, or
```html as appropriate). Locate the affected fenced blocks (the blank fences
shown in the diff) and replace them using the proposed pattern (e.g., ```text
... ```), ensuring each code block reflects its content type for readability and
lint compliance; apply the same change to all other missing fences noted in the
review.
In `@plugins/quarterly-connection/README.md`:
- Line 75: Update the README to make supported file types consistent: change the
bullet "3. **You save documents as .txt or .md files**" to also list .eml (or
otherwise match the wording used in the later section that mentions .eml on
lines 131-133) so both places reflect the same allowed formats; locate and edit
the "You save documents..." bullet and the later file-type guidance section to
ensure they both explicitly list the same extensions (.txt, .md, .eml) or use
identical phrasing.
---
Nitpick comments:
In `@plugins/quarterly-connection/README.md`:
- Line 246: The README currently hardcodes a user-specific path
"/home/claude/.claude/.gh-token"; update the docs to use a portable
home-relative path (e.g. "~/.claude/.gh-token" or mention
"$HOME/.claude/.gh-token") wherever that string appears (see the "**GitHub
Token:** Place in ..." line in README.md) and keep the existing alternative
suggestion to use "gh auth login" so the instruction is generic across
environments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b908229-835d-44fb-ad3f-06875e3180a8
📒 Files selected for processing (8)
.claude-plugin/marketplace.jsonPLUGINS.mddocs/data.jsonplugins/quarterly-connection/.claude-plugin/plugin.jsonplugins/quarterly-connection/README.mdplugins/quarterly-connection/commands/build.mdplugins/quarterly-connection/reference/example-bullets.mdplugins/quarterly-connection/reference/red-hat-competencies.md
✅ Files skipped from review due to trivial changes (4)
- plugins/quarterly-connection/.claude-plugin/plugin.json
- .claude-plugin/marketplace.json
- plugins/quarterly-connection/reference/example-bullets.md
- plugins/quarterly-connection/reference/red-hat-competencies.md
🚧 Files skipped from review as they are similar to previous changes (2)
- PLUGINS.md
- docs/data.json
…nitial release - Add post-generation refinement workflow to build command - Collect PR numbers from git merge commits - Perform thematic review for underrepresented competencies - Validate association between PR/Jira links and accomplishments - Review unlisted work (NO-JIRA commits, tooling contributions) - Review document links for public sharing - Report refinement results in final review step - Prepare plugin for initial release - Use generic placeholders in all documentation and examples - Set version to 0.0.1 - Document command signature: [role] [start-date] [end-date] Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Cursor with Agent: Auto Made-with: Cursor Agent: Auto
jaypoulz
force-pushed
the
feature/format-accomplishments-modern
branch
from
0b9cff1 to
aec2f85
Compare
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(quarterly-connection): add refinement workflow and prepare for initial release
Add post-generation refinement workflow to build command
Prepare plugin for initial release
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Made-with: Cursor
Agent: Auto
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit
New Features
Documentation