-
Notifications
You must be signed in to change notification settings - Fork 150
WIP: testing for qe jobs and commands #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Adds new plugin for listing OpenShift QE Prow upgrade jobs - Command: /prow-qe-jobs:list-qe-jobs [filter-pattern] - Parses CI configs from openshift/release repository - Supports filtering by platform, version, or upgrade type
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dis016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughA new plugin called "prow-qe-jobs" is being registered across the codebase. The plugin includes entries in the marketplace registry and data manifest, along with plugin descriptor metadata and comprehensive documentation files for the plugin and its command. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Hi @dis016. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plugins/prow-qe-jobs/commands/list-qe-jobs.md (1)
11-13: Add language specifiers to fenced code blocks.Markdown linting requires language specifiers on fenced code blocks for accessibility and syntax highlighting. Update the code blocks as follows:
Line 11: Add
bashlanguage specifier-``` +```bash /prow-qe-jobs:list-qe-jobs [filter-pattern] -``` +```Line 54: Add
textorplaintextfor the example output-``` +```text Upgrade Jobs from openshift-tests-private: ... -``` +```Lines 72, 77, 82, 87: Add
bashlanguage specifier to example commands-``` +```bash /prow-qe-jobs:list-qe-jobs -``` +```Also applies to: 54-67, 72-89
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (6)
.claude-plugin/marketplace.json(1 hunks)PLUGINS.md(2 hunks)docs/data.json(1 hunks)plugins/prow-qe-jobs/.claude-plugin/plugin.json(1 hunks)plugins/prow-qe-jobs/README.md(1 hunks)plugins/prow-qe-jobs/commands/list-qe-jobs.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
plugins/prow-qe-jobs/commands/list-qe-jobs.md
11-11: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
54-54: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
72-72: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
77-77: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
82-82: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
87-87: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (6)
plugins/prow-qe-jobs/.claude-plugin/plugin.json (1)
1-8: Plugin descriptor looks solid.The metadata is complete and properly structured. Version and author align with the broader plugin ecosystem.
plugins/prow-qe-jobs/README.md (1)
1-56: Well-structured plugin documentation.The README clearly describes the plugin's purpose, commands, and installation steps. Examples are practical and the contributing section appropriately defers to the shared CLAUDE.md.
.claude-plugin/marketplace.json (1)
132-136: Marketplace entry is properly formatted and positioned.The new plugin entry follows the established pattern and is correctly integrated into the marketplace registry.
PLUGINS.md (1)
25-25: Plugin catalog entry is well-integrated.The TOC entry is properly positioned and the plugin section follows the established documentation pattern with clear command listing and README reference.
Please verify whether the argument format
"[filter-pattern]"with quotes in line 270 is intentional. It differs from the other documentation files (list-qe-jobs.md and README.md) which show the argument without quotes. If these should be consistent, consider aligning the format across all files.Also applies to: 265-272
docs/data.json (1)
979-994: Data manifest entry needs synopsis clarification and quote consistency check.The plugin entry is structurally sound, but two items need verification:
Empty
synopsisfield: Unlike most other commands in this file,synopsisis an empty string. Should it contain/prow-qe-jobs:list-qe-jobs [filter-pattern]for consistency?Escaped quotes in
argument_hint: The value"\"[filter-pattern]\""contains escaped quotes. Verify this is intentional (for downstream tooling) or if it should be simplified to"[filter-pattern]"to match list-qe-jobs.md.plugins/prow-qe-jobs/commands/list-qe-jobs.md (1)
1-99: Comprehensive command documentation with clear structure.The documentation thoroughly describes the command's purpose, implementation steps, usage examples, and important notes. The YAML frontmatter is properly formatted and aligns with the plugin ecosystem.
Summary by CodeRabbit
list-qe-jobscommand with optional filter patterns to discover upgrade jobs from OpenShift test configurations.✏️ Tip: You can customize this high-level summary in your review settings.