Skip to content

Conversation

@dis016
Copy link

@dis016 dis016 commented Dec 7, 2025

Summary by CodeRabbit

  • New Features
    • Added a new OpenShift QE Prow jobs plugin that enables listing and managing Prow jobs from CI configurations. Users can now run the list-qe-jobs command with optional filter patterns to discover upgrade jobs from OpenShift test configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

- Adds new plugin for listing OpenShift QE Prow upgrade jobs
- Command: /prow-qe-jobs:list-qe-jobs [filter-pattern]
- Parses CI configs from openshift/release repository
- Supports filtering by platform, version, or upgrade type
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2025
@openshift-ci openshift-ci bot requested review from mrunalp and stbenjam December 7, 2025 17:19
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dis016
Once this PR has been reviewed and has the lgtm label, please assign stleerh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Walkthrough

A new plugin called "prow-qe-jobs" is being registered across the codebase. The plugin includes entries in the marketplace registry and data manifest, along with plugin descriptor metadata and comprehensive documentation files for the plugin and its command.

Changes

Cohort / File(s) Change Summary
Plugin Registration
.claude-plugin/marketplace.json, docs/data.json, plugins/prow-qe-jobs/.claude-plugin/plugin.json
Added new plugin metadata entries for "prow-qe-jobs" with name, source, description, version (0.0.1), author, and command specifications across registry and descriptor files.
Documentation
PLUGINS.md, plugins/prow-qe-jobs/README.md, plugins/prow-qe-jobs/commands/list-qe-jobs.md
Added plugin catalog documentation including TOC entry, plugin overview in PLUGINS.md, comprehensive README with usage and installation guidance, and detailed command documentation for list-qe-jobs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify plugin metadata consistency across all registry files (.claude-plugin/marketplace.json, docs/data.json, plugin.json)
  • Confirm documentation accuracy and completeness for the list-qe-jobs command
  • Ensure command argument hints and descriptions align with implementation expectations

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'WIP: testing for qe jobs and commands' is vague and does not clearly describe the actual changes. The PR introduces a new prow-qe-jobs plugin with documentation and registry entries, but the title uses generic language that doesn't convey the main purpose or scope of the changeset. Replace with a more descriptive title like 'Add prow-qe-jobs plugin for managing OpenShift QE Prow jobs' to clearly communicate the primary change to reviewers.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
No Real People Names In Style References ✅ Passed Reviewed all modified and added files in the PR; no real people's names used as style references, examples, or documentation.
No Assumed Git Remote Names ✅ Passed No hardcoded git remote names (origin, upstream) found in plugin files, documentation, or configuration.
Git Push Safety Rules ✅ Passed PR contains only documentation and configuration files with no git push commands, shell scripts, or autonomous push workflows.
No Untrusted Mcp Servers ✅ Passed Pull request adds plugin registration and documentation only; no MCP server installations, npm packages, or executable code introduced.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2025

Hi @dis016. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
plugins/prow-qe-jobs/commands/list-qe-jobs.md (1)

11-13: Add language specifiers to fenced code blocks.

Markdown linting requires language specifiers on fenced code blocks for accessibility and syntax highlighting. Update the code blocks as follows:

Line 11: Add bash language specifier

-```
+```bash
 /prow-qe-jobs:list-qe-jobs [filter-pattern]
-```
+```

Line 54: Add text or plaintext for the example output

-```
+```text
 Upgrade Jobs from openshift-tests-private:
 ...
-```
+```

Lines 72, 77, 82, 87: Add bash language specifier to example commands

-```
+```bash
 /prow-qe-jobs:list-qe-jobs
-```
+```

Also applies to: 54-67, 72-89

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between bc9efa5 and 05d48cc.

📒 Files selected for processing (6)
  • .claude-plugin/marketplace.json (1 hunks)
  • PLUGINS.md (2 hunks)
  • docs/data.json (1 hunks)
  • plugins/prow-qe-jobs/.claude-plugin/plugin.json (1 hunks)
  • plugins/prow-qe-jobs/README.md (1 hunks)
  • plugins/prow-qe-jobs/commands/list-qe-jobs.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
plugins/prow-qe-jobs/commands/list-qe-jobs.md

11-11: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


54-54: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


72-72: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


77-77: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


82-82: Fenced code blocks should have a language specified

(MD040, fenced-code-language)


87-87: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🔇 Additional comments (6)
plugins/prow-qe-jobs/.claude-plugin/plugin.json (1)

1-8: Plugin descriptor looks solid.

The metadata is complete and properly structured. Version and author align with the broader plugin ecosystem.

plugins/prow-qe-jobs/README.md (1)

1-56: Well-structured plugin documentation.

The README clearly describes the plugin's purpose, commands, and installation steps. Examples are practical and the contributing section appropriately defers to the shared CLAUDE.md.

.claude-plugin/marketplace.json (1)

132-136: Marketplace entry is properly formatted and positioned.

The new plugin entry follows the established pattern and is correctly integrated into the marketplace registry.

PLUGINS.md (1)

25-25: Plugin catalog entry is well-integrated.

The TOC entry is properly positioned and the plugin section follows the established documentation pattern with clear command listing and README reference.

Please verify whether the argument format "[filter-pattern]" with quotes in line 270 is intentional. It differs from the other documentation files (list-qe-jobs.md and README.md) which show the argument without quotes. If these should be consistent, consider aligning the format across all files.

Also applies to: 265-272

docs/data.json (1)

979-994: Data manifest entry needs synopsis clarification and quote consistency check.

The plugin entry is structurally sound, but two items need verification:

  1. Empty synopsis field: Unlike most other commands in this file, synopsis is an empty string. Should it contain /prow-qe-jobs:list-qe-jobs [filter-pattern] for consistency?

  2. Escaped quotes in argument_hint: The value "\"[filter-pattern]\"" contains escaped quotes. Verify this is intentional (for downstream tooling) or if it should be simplified to "[filter-pattern]" to match list-qe-jobs.md.

plugins/prow-qe-jobs/commands/list-qe-jobs.md (1)

1-99: Comprehensive command documentation with clear structure.

The documentation thoroughly describes the command's purpose, implementation steps, usage examples, and important notes. The YAML frontmatter is properly formatted and aligns with the plugin ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant