CNTRLPLANE-631: Handle node-ca daemon removal in monitoring exceptions - #2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Add NodeCADaemonRemoved reason to the image-registry operator exception handlers for both degraded state and progressing state transitions. This ensures that when the node-ca daemon set is removed (as part of the MCO-based image registry CA distribution), the monitoring tests correctly handle the transient degraded/progressing conditions. Ref: CNTRLPLANE-631 Co-Authored-By: brcox <brcox@redhat.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
/close |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
"NodeCADaemonRemoved"as an accepted exception reason for theimage-registrycluster operator in two upgrade monitoring test paths:testUpgradeOperatorStateTransitions): When image-registry reportsDegraded=Truewith reasonNodeCADaemonRemoved, it is now treated as a known issue (OCPBUGS-66225) rather than a test failure.testUpgradeOperatorProgressingStateTransitions): When image-registry reportsProgressing=Truewith reasonNodeCADaemonRemoved, it is treated as a known issue (OCPBUGS-62626).This supports the broader CNTRLPLANE-631 effort to distribute the image registry CA via MCO bootstrap (
--bootstrap-certs) in HyperShift, which will eventually allow removal of the node-ca daemon set.Review & Testing Checklist for Human
"NodeCADaemonRemoved"reason string matches what the image-registry operator will actually emit. This string does not currently exist anywhere in the codebase — it is a forward-looking addition. If the image-registry operator uses a different reason string when the node-ca daemonset is removed, this exception will silently never match.Notes
Part of a three-repo change set for CNTRLPLANE-631. Companion PRs exist in
openshift-devin/enhancements(enhancement doc update) andopenshift-devin/cluster-version-operator(CVO render--image-registry-ca-fileflag).Link to Devin Session: https://redhat.devinenterprise.com/sessions/53fe46443c224d87b66235e740659631
Requested by: brcox