CNTRLPLANE-631: Update enhancement doc for HyperShift image registry CA via MCO - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Add HyperShift-specific workflow documenting how the image registry CA is distributed to worker nodes via MCO bootstrap mode using the --bootstrap-certs flag (MCO PR #3876). Includes: - HyperShift workflow section describing the end-to-end flow - Updated user stories, goals, and non-goals - Test plan for both standalone and HyperShift clusters - Upgrade/downgrade strategy - Implementation history Ref: CNTRLPLANE-631 Co-Authored-By: brcox <brcox@redhat.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
/close |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNTRLPLANE-631: Install image registry CA via MCO in HyperShift
Summary
Implements partial support for distributing the image registry CA to HyperShift worker nodes via MCO bootstrap mode, building on the merged MCO PR #3876 which added the
--bootstrap-certsflag.Changes span three repos:
openshift-devin/enhancements
enhancements/machine-config/certificate-authorities-for-image-registries.mdwith a new "HyperShift Workflow" section documenting the end-to-end flow (service-ca → CPO → CVO render → MCO bootstrap → ignition → worker node)openshift-devin/cluster-version-operator
--image-registry-ca-fileflag to therendersubcommandcopyImageRegistryCA()function that copies the CA file into the bootstrap output directory for MCO consumptionRender()function signature to thread the new parameter throughopenshift-devin/origin
"NodeCADaemonRemoved"to the image-registry operator exception handlers in both the degraded-state and progressing-state transition monitorsReview & Testing Checklist for Human
"NodeCADaemonRemoved"reason string: This is speculative — confirm this matches the actual reason the image-registry operator will emit when the node-ca daemon set is removed. If the operator uses a different string, the monitoring exceptions won't fire correctly.copyImageRegistryCAdestination filename contract: The function usesfilepath.Base(caFile)for the output filename. The control-plane-operator must reference the same filename when passing--bootstrap-certsto MCO. Confirm this naming convention is agreed upon across components.copyImageRegistryCA: The new CVO function has no test coverage. Consider whether a test should be added for the file-copy logic and error handling paths.cvo render --image-registry-ca-file.Notes
These changes are part of a larger multi-repo effort tracked in CNTRLPLANE-631. This PR implements:
NOT included (tracked separately):
cvo render --image-registry-ca-fileRelated PR: MCO #3876 (merged) which added the
--bootstrap-certsflag to machine-config-server.Link to Devin Session: https://redhat.devinenterprise.com/sessions/53fe46443c224d87b66235e740659631
Requested by: brcox