CNTRLPLANE-631: Add --image-registry-ca-file flag to render command - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Add support for copying the image registry CA certificate to the bootstrap output directory during CVO render. This enables the MCO bootstrap server to include the CA in the ignition payload via its --bootstrap-certs flag for HyperShift hosted clusters. Changes: - Add --image-registry-ca-file flag to render command - Add copyImageRegistryCA function to copy CA to bootstrap dir - Update Render function signature to accept imageRegistryCAFile param Ref: CNTRLPLANE-631 Co-Authored-By: brcox <brcox@redhat.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
/close |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CNTRLPLANE-631: Install image registry CA via MCO in HyperShift
Summary
Adds support for distributing the image registry CA to HyperShift worker nodes via the MCO bootstrap ignition payload, replacing the dependency on the node-ca daemonset. Changes span three repositories:
cluster-version-operator: Adds
--image-registry-ca-fileflag to the CVOrendercommand. When provided, the CA file is copied into the bootstrap output directory so the MCO bootstrap server can consume it via its--bootstrap-certsflag (added in MCO PR #3876).enhancements: Updates the
certificate-authorities-for-image-registries.mdenhancement with a HyperShift-specific workflow section, concrete user stories, test plan, and upgrade/downgrade strategy.origin: Adds
NodeCADaemonRemovedto the image-registry operator exception handlers in monitoring tests, so transient degraded/progressing conditions during node-ca removal don't cause test failures.Review & Testing Checklist for Human
NodeCADaemonRemovedis the correct reason string — The origin changes add this as a known exception reason, but this string must match what the image-registry operator will actually emit when the node-ca daemonset is removed. Confirm this with the image-registry team or check the corresponding image-registry-operator PR.copyImageRegistryCAdestination filename convention — The function usesfilepath.Base(caFile)for the output filename. The HyperShift CPO must pass a matching filename to MCO's--bootstrap-certsflag (e.g.,image-registry.openshift-image-registry.svc:5000=image-registry-ca.crt). This coupling is implicit — confirm the CPO side will use the expected filename.copyImageRegistryCA— The new CVO function is a straightforward file copy but has no dedicated test. Consider whether this needs coverage or if integration testing via the CPO is sufficient.--image-registry-ca-fileand configure MCO bootstrap with--bootstrap-certs. Verify that the corresponding CPO PR exists and aligns with these changes.Test Plan
Since this is HyperShift-specific, the full flow requires a HyperShift cluster:
--image-registry-ca-file)/etc/docker/certs.d/image-registry.openshift-image-registry.svc:5000/ca.crton worker nodesNotes