This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
bug(*): Fix memory targetAverageUtilization #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update HPA yamls from averageValue to averageUtilization and resolves openservicemesh#4451 Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
shalier
requested review from
draychev,
jaellio,
nojnhuh,
shashankram and
snehachhabria
as code owners
allenlsy
approved these changes
Jan 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #4453 +/- ##
==========================================
+ Coverage 69.14% 69.19% +0.04%
==========================================
Files 212 212
Lines 14580 14580
==========================================
+ Hits 10082 10088 +6
+ Misses 4446 4440 -6
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update HPA yamls from averageValue to averageUtilization
and resolves #4451
Signed-off-by: Shalier Xia shalierxia@microsoft.com
Testing done:
Ran HPA enabled for osmController and injector for bookstore demo and percentages are seen for both CPU and memory utilization.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no