This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(upgrade): handle removed values #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the e2e_upgrade_test passes with this change. Should we enable that test in the CI? |
|
Yes, those changes are included here. |
Currently, upgrading OSM with `osm mesh upgrade` fails when the newer chart version removes or renames values from the installed chart because values.schema.json defines `"additionalProperties": false` on each object and `osm mesh upgrade` uses all the values from the installed chart. Now, the `osm mesh upgrade` command will not use any values from the old release. Users can specify them with the new `--set` flag. Fixes #4330 Signed-off-by: Jon Huhn <johuhn@microsoft.com>
nojnhuh
requested review from
draychev,
eduser25,
michelleN,
shashankram and
snehachhabria
as code owners
shashankram
approved these changes
Nov 4, 2021
snehachhabria
approved these changes
Nov 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, upgrading OSM with
osm mesh upgradefails when the newerchart version removes or renames values from the installed chart because
values.schema.json defines
"additionalProperties": falseon eachobject and
osm mesh upgradeuses all the values from the installedchart.
Now, the
osm mesh upgradecommand will not use any values from the oldrelease. Users can specify them with the new
--setflag.Fixes #4330
Testing done: Manually ran affected tests and other upgrade scenarios based on the existing e2e test.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? Yes, release notes have been updated.