Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Ensure single mesh deployment is enforced in OSM by default #4192

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

snehachhabria
Copy link
Contributor

Description:

Enforcing single mesh in a cluster by defalut for OSM.

part of #4162

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [X]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Enforcing single mesh in a cluster by defalut for OSM.

part of openservicemesh#4162

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria requested a review from a team as a code owner September 29, 2021 23:23
@codecov-commenter
Copy link

Codecov Report

Merging #4192 (521679a) into main (5c9b998) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4192      +/-   ##
==========================================
+ Coverage   69.83%   69.87%   +0.03%     
==========================================
  Files         212      212              
  Lines       11623    11623              
==========================================
+ Hits         8117     8121       +4     
+ Misses       3454     3450       -4     
  Partials       52       52              
Flag Coverage Δ
unittests 69.87% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/cli/install.go 81.34% <ø> (ø)
pkg/crdconversion/crdconversion.go 71.42% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9b998...521679a. Read the comment docs.

@snehachhabria snehachhabria merged commit 7076b8a into openservicemesh:main Sep 30, 2021
@snehachhabria snehachhabria deleted the enforceSingleMesh branch September 30, 2021 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce that there can be only one OSM control plane on a cluster
4 participants