build: update to Go 1.17 (#4410)

* build: update to Go 1.17 Go 1.17 introduces compiler improvement (https://golang.org/doc/go1.17#compiler) and supports module graph pruning (https://golang.org/ref/mod#graph-pruning) and lazy module loading (https://golang.org/ref/mod#lazy-loading). Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * build: update generated code for Go 1.17 Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * test: regenerating public test cert for TestCertificaterFromCertificateRequest Reference: #4410 (comment) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
openservicemesh · Jan 6, 2022 · 89b5661 · 89b5661
1 parent ce6d63d
commit 89b5661
Show file tree

Hide file tree

Showing 16 changed files with 312 additions and 92 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -40,10 +40,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v1
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: go build deps
         run: make embed-files-test
       - name: golangci-lint
@@ -59,10 +59,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v1
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: go mod tidy
         run: make go-mod-tidy
       - name: Codegen checks
@@ -74,10 +74,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v1
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: go mod tidy
         run: make go-mod-tidy
       - name: gomock checks
@@ -110,10 +110,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Go Build
         run: make build-ci
 
@@ -136,10 +136,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: go mod tidy
         run: make go-mod-tidy
       - name: Test
@@ -169,10 +169,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Test
         run: |
           touch .env
@@ -184,7 +184,7 @@ jobs:
     name: Scan images for security vulnerabilities
     runs-on: ubuntu-latest
     needs: build
-    env: 
+    env:
       CTR_TAG: ${{ github.sha }}
       CTR_REGISTRY: "localhost:5000"
     steps:
@@ -202,10 +202,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Build docker images
         run: make docker-build-osm-controller docker-build-osm-injector docker-build-osm-crds docker-build-osm-bootstrap docker-build-init
       - name: Scan docker images for vulnerabilities
@@ -236,10 +236,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Build test dependencies
         run: make docker-build-osm-controller docker-build-osm-injector docker-build-osm-crds docker-build-osm-bootstrap docker-build-init build-osm docker-build-tcp-echo-server
       # PR Tests
@@ -306,10 +306,10 @@ jobs:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
 
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
         id: go
 
       - name: Run Simulation w/ Tresor, SMI policies, egress disabled and reconciler disabled
@@ -328,7 +328,6 @@ jobs:
           ./demo/run-osm-demo.sh
           go run ./ci/cmd/maestro.go
 
-
   images:
     name: Docker Images
     runs-on: ubuntu-latest
@@ -351,10 +350,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Docker Login
         run: docker login --username "$DOCKER_USER" --password-stdin <<< "$DOCKER_PASS"
       - name: Push images with git sha tag

diff --git a/.github/workflows/nightly-images.yml b/.github/workflows/nightly-images.yml
@@ -1,5 +1,5 @@
 name: Nightly Images
-on: 
+on:
   schedule:
     - cron: "0 0 * * *"
 
@@ -25,10 +25,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Docker Login
         run: docker login --username "$DOCKER_USER" --password-stdin <<< "$DOCKER_PASS"
       - name: Push images with git sha tag

diff --git a/.github/workflows/nightly-noinstall.yml b/.github/workflows/nightly-noinstall.yml
@@ -1,5 +1,5 @@
 name: OSM NoInstall Nightly Job
-on: 
+on:
   workflow_run:
     workflows: ["Nightly Images"]
     types: [completed]
@@ -38,7 +38,7 @@ jobs:
             extraPortMappings:
             - containerPort: 80
               hostPort: 80
-              protocol: TCP          
+              protocol: TCP
           - role: worker
           EOF
 
@@ -50,10 +50,10 @@ jobs:
         run: |
           kubectl version
           kubectl get nodes
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Install OSM via OSM CLI
         run: |
           make build-osm

diff --git a/.github/workflows/openshift-nightly.yml b/.github/workflows/openshift-nightly.yml
@@ -1,5 +1,5 @@
 name: OpenShift Nightly Job
-on: 
+on:
   workflow_run:
     workflows: ["Nightly Images"]
     types: [completed]
@@ -24,10 +24,10 @@ jobs:
           insecure_skip_tls_verify: true
       - name: Test oc
         run: oc version --client
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Run e2es
         run: |
           make build-osm

diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -26,7 +26,7 @@ jobs:
       DOCKER_USER: ${{ secrets.RELEASE_DOCKER_USER }}
       DOCKER_PASS: ${{ secrets.RELEASE_DOCKER_PASS }}
       VERSION: ${{ needs.version.outputs.version }}
-      BUILD_DATE: '$$(date +%Y-%m-%d-%H:%M)'
+      BUILD_DATE: "$$(date +%Y-%m-%d-%H:%M)"
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -42,10 +42,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Docker Login
         run: docker login --username "$DOCKER_USER" --password-stdin <<< "$DOCKER_PASS"
       - name: Push images with version tag
@@ -86,4 +86,4 @@ jobs:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
       - name: Scan docker images for vulnerabilities
-        run: make trivy-scan-images
+        run: make trivy-scan-images
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -39,10 +39,10 @@ jobs:
         with:
           path: ~/.cache/go-build
           key: ${{ runner.os }}-gobuild-${{ hashFiles('**/*.go') }}
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Build Binaries
         run: |
           make release-artifacts

diff --git a/.github/workflows/windows-nightly.yml b/.github/workflows/windows-nightly.yml
@@ -1,5 +1,5 @@
 name: Windows Nightly Job
-on: 
+on:
   workflow_run:
     workflows: ["Nightly Images"]
     types: [completed]
@@ -22,10 +22,10 @@ jobs:
           method: kubeconfig
           kubeconfig: ${{ secrets.CI_WINDOWS_KUBECONFIG }}
         id: setcontext
-      - name: Setup Go 1.16
-        uses: actions/setup-go@v1
+      - name: Setup Go 1.17
+        uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
       - name: Run e2es
         run: |
           make build-osm

diff --git a/Dockerfile b/Dockerfile
@@ -1,6 +1,6 @@
 
 #build stage
-FROM golang:1.16-alpine AS builder
+FROM golang:1.17-alpine AS builder
 
 RUN apk update
 RUN apk add --no-cache make

diff --git a/demo/README.md b/demo/README.md
@@ -3,7 +3,7 @@
 ## System Requirements
 - MacOS, Linux or WSL2 on Windows
 - GCC
-- Go version [1.16.0 or higher](https://github.com/openservicemesh/osm/issues/2363)
+- Go version [1.17.0 or higher](https://github.com/openservicemesh/osm/issues/2363)
 - Kubectl version 1.15 or higher
 - Docker CLI
    - on a Debian based GNU/Linux system: `sudo apt-get install docker`

diff --git a/docs/development_guide/README.md b/docs/development_guide/README.md
@@ -63,7 +63,7 @@ OSM leverages [Envoy proxy](https://github.com/envoyproxy/envoy) as a data plane
 
 ## Get Go-ing
 
-This Open Service Mesh project uses [Go v1.16.0+](https://golang.org/). If you are not familiar with Go, spend some time with the excellent [Tour of Go](https://tour.golang.org/).
+This Open Service Mesh project uses [Go v1.17.0+](https://golang.org/). If you are not familiar with Go, spend some time with the excellent [Tour of Go](https://tour.golang.org/).
 
 ## Get the dependencies