Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove watches at runtime | 怎样在运行过程中,移除对 k8s 中 CRD的watcher #23

Open
jnan806 opened this issue Nov 9, 2022 · 7 comments
Labels
area/crd-watcher Category issues or PRs related to CRD watcher

Comments

@jnan806
Copy link
Collaborator

jnan806 commented Nov 9, 2022

In current version, the watches for CRD in kubernetes can be added when the OpenSergo SDK start a SubscribeConfig request. But when I try to remove the watches when receive an unSubscribeConfig request, I found there is no function in client-go of kubernetes to deal with it.

So, I try to find a solution in official project. There are some relation issues, maybe we can fix this issue according to the official issue.

The official issue refers to kubernetes-sigs/controller-runtime#1884

@jnan806 jnan806 added the area/crd-watcher Category issues or PRs related to CRD watcher label Nov 9, 2022
@jnan806
Copy link
Collaborator Author

jnan806 commented Nov 13, 2022

new progress: feature will be supported in version v0.26.0-alpha.3 of kuberneres.

detail refer to official issue 1884 which this issue has commented above.

@jnan806
Copy link
Collaborator Author

jnan806 commented Nov 15, 2022

new progress: version of kuberneres in kuberneres-sigs/controller-runtime has been bumped into v0.26.0-alpha.3.
this feature PR of Support registration and removal of event handler is committed by contributor, and waiting for merging by official.

The official PR refers to kubernetes-sigs/controller-runtime#2046

@jnan806
Copy link
Collaborator Author

jnan806 commented Nov 16, 2022

new progress: feature will be supported in version v0.26.0-alpha.3 of kuberneres-sigs/controller-runtime, the PR has been merged.
And we need waiting for a release version of kubernetes-sigs/controller-runtime or use the master branch of kubernetes-sigs/controller-runtime

relation ISSUE refers to kubernetes-sigs/controller-runtime#2047

@camilamacedo86
Copy link

It seems not supported so far see: kubernetes-sigs/controller-runtime#1884

@jnan806
Copy link
Collaborator Author

jnan806 commented Nov 17, 2022

It seems not supported so far see: kubernetes-sigs/controller-runtime#1884

I'm very looking forward to it ~

@jnan806
Copy link
Collaborator Author

jnan806 commented Dec 14, 2022

related PR (kubernetes-sigs/controller-runtime#2099) has been posted by official.

we can deal with it after the PR merged ~

@jnan806
Copy link
Collaborator Author

jnan806 commented Feb 3, 2023

The old PR is closed in official, and a new one is open kubernetes-sigs/controller-runtime#2159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/crd-watcher Category issues or PRs related to CRD watcher
Projects
None yet
Development

No branches or pull requests

2 participants