Support shutdown controller to shutdown watching like SetupWithManager() to start watching.

[jnan806]

What do you want to happen?

Now, we can setup a controller with the Manager to start watching resource, but there is no function to shutdown the controller has be setup by Manager.

If i want to shutdown the controller which has be setupped, i found there is no way.

[FillZpp]

@jnan806 That can be supported with the watch removal. #1884

[jnan806]

@jnan806 That can be supported with the watch removal. kubernetes-sigs/controller-runtime#1884

the version was commented in that ISSUE looks does not work.

[jnan806]

@jnan806 That can be supported with the watch removal. kubernetes-sigs/controller-runtime#1884

close issue and refer to above

[jnan806]

re-open
I has saw PR of Support registration and removal of event handler is merged in #2046.
And how we can use it by ShutdownWithManager() to removal handler like register Reconciler in SetupWithManager()
ctrl.NewControllerManagedBy(mgr).For(...).Complete(r)

[camilamacedo86]

I transfered this one for controller-runtime
However, @jnan806 after you check it out if you would like to collab with a doc/guidance to the kubebuilder project with that would be amazing.

[jnan806]

However, @jnan806 after you check it out if you would like to collab with a doc/guidance to the kubebuilder project with that would be amazing.

😂 I am only in the stage of using this product, and my tech has not reached the stage of contributing it.

And i am waiting for how to remove watch by ctrl.NewControllerManagedBy(mgr).For(...).Cancel(r) like ctrl.NewControllerManagedBy(mgr).For(...).Complete(r).

Does controller-runtime will support it ?

[camilamacedo86]

Hi @jnan806,

Does controller-runtime will support it ?

It seems not supported but has an open issue for it: #1884

[FillZpp]

It seems not supported but has an open issue for it: #1884

Yeah, I'm working on the issue.

[jnan806]

Yeah, I'm working on the issue.

I'm very looking forward to it ~ 😄

[camilamacedo86]

Closing as duplicated of : #1884