Skip to content

Conversation

@penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 31, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

  • Add generice StreamingSource interface.
  • Add FileSystemStreamingSource implementation base on hadoop fs.
  • Exclude uncessary depedency from hadoop-commons, the opensearch-sql.zip size is around 50M. (currently, 33M)
  • More info Add Stream Source #969.

Future Work

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (eea2689) to head (e2e3cd8).
⚠️ Report is 18 commits behind head on feature/maximus-m1.

❌ Your project status has failed because the head coverage (95.75%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/maximus-m1     #994      +/-   ##
========================================================
- Coverage                 98.27%   95.75%   -2.53%     
- Complexity                 3396     3405       +9     
========================================================
  Files                       339      350      +11     
  Lines                      8545     9241     +696     
  Branches                    561      682     +121     
========================================================
+ Hits                       8398     8849     +451     
- Misses                      142      334     +192     
- Partials                      5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo force-pushed the hp/feature/maximus/streamingsource branch from 9776f9d to 7b6a1e2 Compare November 1, 2022 16:17
@penghuo penghuo added the feature label Nov 1, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo self-assigned this Nov 1, 2022
@penghuo penghuo marked this pull request as ready for review November 1, 2022 18:53
@penghuo penghuo requested a review from a team as a code owner November 1, 2022 18:53
@penghuo penghuo marked this pull request as draft November 3, 2022 04:13
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review November 3, 2022 23:49
Signed-off-by: Peng Huo <penghuo@gmail.com>
…urce

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen merged commit 5105022 into opensearch-project:feature/maximus-m1 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants