Skip to content

Conversation

@penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 26, 2022

Changes

  1. Add metadatalog interface which is used by stream source, microbatch execution.
  2. Add default in memory implementation of metadatalog.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo requested a review from a team as a code owner October 26, 2022 21:57
@penghuo penghuo added the enhancement New feature or request label Oct 26, 2022
@penghuo penghuo self-assigned this Oct 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (3a9d217) to head (7c399f2).
⚠️ Report is 85 commits behind head on feature/maximus-m1.

❌ Your project status has failed because the head coverage (94.90%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/maximus-m1     #974      +/-   ##
========================================================
- Coverage                 97.95%   94.90%   -3.06%     
- Complexity                 3143     3177      +34     
========================================================
  Files                       300      317      +17     
  Lines                      7784     8556     +772     
  Branches                    500      632     +132     
========================================================
+ Hits                       7625     8120     +495     
- Misses                      158      382     +224     
- Partials                      1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.58% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penghuo penghuo added this to the Maximus M1 - Phase 1 milestone Oct 26, 2022
Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo merged commit 63f3449 into opensearch-project:feature/maximus-m1 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants