Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List tables/metrics using information_schema in source command. #914

Merged

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Oct 13, 2022

Signed-off-by: vamsi-amazon reddyvam@amazon.com

Description

List Metrics using information_schema in source command.
Example commands.

List all tables/metrics.

  • source = prometheus.information_schema.tables

Issues Resolved

#986

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsi-amazon vamsi-amazon force-pushed the describe-table-prometheus branch 2 times, most recently from 05f11cc to cce8352 Compare October 13, 2022 21:55
@vamsi-amazon vamsi-amazon changed the title Restricted catalog name to [a-zA-Z0-9_-] characters Describe Metric and List Metrics Changes Oct 13, 2022
@vamsi-amazon vamsi-amazon changed the title Describe Metric and List Metrics Changes Describe Metric and List Metrics(SHOW TABLES) Changes Oct 14, 2022
@vamsi-amazon vamsi-amazon changed the title Describe Metric and List Metrics(SHOW TABLES) Changes Describe TABLE(describe metric) and SHOW TABLES (List Metrics) Changes Oct 14, 2022
@vamsi-amazon vamsi-amazon force-pushed the describe-table-prometheus branch 21 times, most recently from ac74d02 to 2481429 Compare October 21, 2022 10:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #914 (fdf926e) into 2.x (b843639) will decrease coverage by 2.62%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #914      +/-   ##
============================================
- Coverage     97.57%   94.95%   -2.63%     
- Complexity     3153     3185      +32     
============================================
  Files           305      318      +13     
  Lines          7874     8641     +767     
  Branches        512      639     +127     
============================================
+ Hits           7683     8205     +522     
- Misses          190      382     +192     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.60% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/sql/storage/StorageEngine.java 100.00% <ø> (ø)
...ql/opensearch/storage/OpenSearchStorageEngine.java 100.00% <ø> (ø)
...rg/opensearch/sql/ppl/config/PPLServiceConfig.java 100.00% <ø> (ø)
...theus/data/constants/PrometheusFieldConstants.java 0.00% <ø> (ø)
...rage/implementor/PrometheusDefaultImplementor.java 100.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
.../analysis/CatalogSchemaIdentifierNameResolver.java 100.00% <100.00%> (ø)
...ava/org/opensearch/sql/utils/SystemIndexUtils.java 100.00% <100.00%> (ø)
...ch/sql/prometheus/client/PrometheusClientImpl.java 100.00% <100.00%> (ø)
...equest/system/PrometheusDescribeMetricRequest.java 100.00% <100.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vamsi-amazon vamsi-amazon changed the title Describe TABLE(describe metric) and List TABLES (List Metrics) Changes List tables/metrics using information_schema. Oct 28, 2022
@vamsi-amazon vamsi-amazon changed the title List tables/metrics using information_schema. List tables/metrics using information_schema in source command. Oct 28, 2022
@vamsi-amazon vamsi-amazon added enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 28, 2022
@vamsi-amazon vamsi-amazon force-pushed the describe-table-prometheus branch 8 times, most recently from d885d41 to 2881a8c Compare October 28, 2022 03:59
@vamsi-amazon vamsi-amazon marked this pull request as ready for review October 28, 2022 04:03
penghuo
penghuo previously approved these changes Oct 28, 2022
@vamsi-amazon vamsi-amazon force-pushed the describe-table-prometheus branch 2 times, most recently from c35e089 to 67db797 Compare October 28, 2022 19:26
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vamsi-amazon vamsi-amazon merged commit e3fe086 into opensearch-project:2.x Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement List of metrics available in Prometheus with all the metadata Information
5 participants