Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support link for Tableau connector #643

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

It was requested that the support link for Tableau connector to be updated from a GitHub link to OpenSearch.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 2 commits June 17, 2022 11:20
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Update support link as it was requested by Salesforce.
@codecov-commenter
Copy link

Codecov Report

Merging #643 (d3ae8aa) into main (d81ef73) will decrease coverage by 31.87%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #643       +/-   ##
=============================================
- Coverage     94.63%   62.76%   -31.88%     
=============================================
  Files           279       10      -269     
  Lines          7517      658     -6859     
  Branches        556      118      -438     
=============================================
- Hits           7114      413     -6701     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...search/sql/expression/datetime/IntervalClause.java
.../org/opensearch/sql/sql/antlr/SQLSyntaxParser.java
...nsearch/sql/storage/bindingtuple/BindingTuple.java
...pensearch/sql/planner/physical/RemoveOperator.java
...ch/sql/expression/aggregation/CountAggregator.java
...sql/expression/datetime/DateTimeFormatterUtil.java
...ch/sql/opensearch/client/OpenSearchRestClient.java
...a/org/opensearch/sql/utils/MLCommonsConstants.java
...earch/storage/script/filter/lucene/RangeQuery.java
.../org/opensearch/sql/ppl/antlr/PPLSyntaxParser.java
... and 259 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81ef73...d3ae8aa. Read the comment docs.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@penghuo penghuo merged commit 499c130 into opensearch-project:main Jul 7, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the integ-connector-update-link branch September 9, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants