[Backport 2.19-dev] Implement Append command with Calcite (#4123)
#4244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement Append Command Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix spotless check Signed-off-by: Songkan Tang <songkant@amazon.com> * Rephrase append.rst Signed-off-by: Songkan Tang <songkant@amazon.com> * Support subsearch different index for append command Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix some tests and add cross cluster IT Signed-off-by: Songkan Tang <songkant@amazon.com> * Not support empty subsearch input for now Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix doctest Signed-off-by: Songkan Tang <songkant@amazon.com> * Support empty source edge case Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix anonymizer tests Signed-off-by: Songkan Tang <songkant@amazon.com> * Add missing test cases for nested join or lookup command in appended subsearch Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix compile issue Signed-off-by: Songkan Tang <songkant@amazon.com> --------- Signed-off-by: Songkan Tang <songkant@amazon.com>
songkant-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
yuancu
previously approved these changes
Sep 8, 2025
|
@songkant-aws please resolve the conflicts |
yuancu
approved these changes
Sep 10, 2025
LantaoJin
approved these changes
Sep 10, 2025
LantaoJin
merged commit 10b5b49
into
opensearch-project:2.19-dev
69 of 70 checks passed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Append Command
Fix spotless check
Rephrase append.rst
Support subsearch different index for append command
Fix some tests and add cross cluster IT
Not support empty subsearch input for now
Fix doctest
Support empty source edge case
Fix anonymizer tests
Add missing test cases for nested join or lookup command in appended subsearch
Fix compile issue
Description
Manual backport #4123 into 2.19-dev
Related Issues
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.