-
Notifications
You must be signed in to change notification settings - Fork 176
Run unit test suites in parallel #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run unit test suites in parallel #4190
Conversation
Signed-off-by: Simeon Widdis <sawiddis@gmail.com>
I haven't tested out but thanks for doing this. |
Does this fixing save time of integ-test for building locally with |
It reduces the github CI but not very much -- the individual tasks are parallelized now (so e.g. The problem with enabling parallelism between tasks right now is it seems there's an invisible dependency for Something we could do is break up our testing action into unit tests, integTest, and doctest as three different actions. Then we run |
#4193, looks like it works. If preferred, close this in favor of that, but I'd rather get this merged quicker since it has immediate benefit for local development, and don't want to block this on any issues with those (riskier) CI updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Could u update doc also. https://github.com/opensearch-project/sql/blob/main/DEVELOPER_GUIDE.rst#building-and-running-tests
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Test failures pending #4215, was passing before doc update |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This reverts commit 65461ad. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
f99b5c7
to
ea3420a
Compare
Description
Our unit tests don't have any cross-dependency, so we can freely turn on parallelization for them. Makes builds a bit faster locally. (At least the parts where most of the feedback is -- async is still slow but now it runs at the end instead of the start, and will rarely fail when working on anything that isn't specifically async.)
Related Issues
Slow local builds. I want
./gradlew -x doctest -x integTest --parallel
to be fast.Check List
--signoff
or-s
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.