-
Notifications
You must be signed in to change notification settings - Fork 163
Support struct field with dynamic disabled #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Heng Qian <qianheng@amazon.com>
Another issue is that we don't serialize json whose value is null. For example:
We will currently get result for PPL
But will get this if configuring
Which result do we want to generate? I would prefer the latter one. Shall we fix this as well? @penghuo |
+1 for serializeNulls |
return ExprNullValue.of(); | ||
} | ||
|
||
if (fieldType.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some comment to explain why we parse context when field type is not present?
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
* Support struct field with dynamic disabled Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix UT Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit 76b3ec2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Support struct field with dynamic disabled Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix UT Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit 76b3ec2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Support struct field with dynamic disabled * Fix UT * Address comments * Revert change in GSON * Revert change in GSON --------- (cherry picked from commit 76b3ec2) Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Support struct field with dynamic disabled (#3829) * Support struct field with dynamic disabled Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix UT Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> * Revert change in GSON Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> (cherry picked from commit 76b3ec2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix compiling error Signed-off-by: Heng Qian <qianheng@amazon.com> * Add UT Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Heng Qian <qianheng@amazon.com>
Description
Support struct field with dynamic disabled
If dynamic mapping disabled, although information of type missed for the new added fields, we can still parse value from the content by itself only.
Related Issues
Resolves #3343
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.