-
Couldn't load subscription status.
- Fork 176
Modified workflow: Grammar Files & Async Query Core #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several duplicate logics defined on grammar flow and async-query-core flow. Can we refactor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Let's also ensure that no new syntax or grammar is introduced from g4 files; everything should be the same as the current ones on main branch
Signed-off-by: Kai Huang <ahkcs@amazon.com>
1197029 to
86a10af
Compare
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3715-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5eb2e5ba9bb3cea40beacd2fae4d180480c9ed93
# Push it to GitHub
git push --set-upstream origin backport/backport-3715-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
|
can you double check the versioning of async-query-core? on 2.x it should starts from 0.1.0 |
It extracts version from build.gradle(async-query-core) file, which is set to be 1.0.0 on main, should I modify it? |
Description
Publish to Maven: Grammar Files & Async Query Core
This PR adds a GitHub Actions workflow to automate the publication of artifacts to the Maven snapshot repository for the language-grammar package and the async-query-core module.
Key FeaturesCollects .g4 ANTLR grammar files from the language-grammar module.
Packages them into a .zip artifact with a generated POM.
Publishes the zip artifact to Maven snapshot repo under org.opensearch:language-grammar.
Injects the current Git commit SHA into maven-metadata.xml as for traceability.
Builds a shaded JAR (shadowJar) of the async-query-core module using Gradle.
Prepares and publishes the JAR and generated POM to Maven snapshot repo under org.opensearch:async-query-core.
Similarly injects the current Git commit SHA into version metadata.