Skip to content

Conversation

@ahkcs
Copy link
Contributor

@ahkcs ahkcs commented May 21, 2025

create a new directory https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/direct-query/

This PR did the directory creation job for #3648 , so that PR#3648 can build the async-query-core shadow JAR and publishes it to the Sonatype snapshots repository under the org.opensearch.direct-query group ID.

ahkcs added 2 commits May 21, 2025 10:52
…y-core and add last commit_id to the metadata file

Signed-off-by: Kai Huang <ahkcs@amazon.com>
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/repositories/snapshots/org/opensearch/direct-query-poc/async-query-core

can we do

/repositories/snapshots/org/opensearch/direct-query only?

if not let's do

/repositories/snapshots/org/opensearch/async-query-core

@ahkcs
Copy link
Contributor Author

ahkcs commented May 21, 2025

/repositories/snapshots/org/opensearch/direct-query-poc/async-query-core

can we do

/repositories/snapshots/org/opensearch/direct-query only?

if not let's do

/repositories/snapshots/org/opensearch/async-query-core

We can do /repositories/snapshots/org/opensearch/direct-query

@ahkcs ahkcs changed the title create a new directory https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/direct-query/ create a new directory org/opensearch/direct-query/ May 21, 2025
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a little more details in PR description? Currently the title and description is more like a commit instead of a PR.

@ahkcs
Copy link
Contributor Author

ahkcs commented May 21, 2025

Could you add a little more details in PR description? Currently the title and description is more like a commit instead of a PR.

Added more details, this PR creates the directory #3648 will later use, and then this PR will be overwritten by PR#3648

@noCharger noCharger merged commit e4838ec into opensearch-project:main May 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants