Support fillnull command with Calcite
#3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
penghuo
reviewed
May 20, 2025
docs/user/ppl/cmd/fillnull.rst
Outdated
| Example 1: fillnull one field | ||
| ====================================================================== | ||
| * replacement: mandatory. The value used to replace `null`s. | ||
| * field-list: optional. The comma-delimited field list. The `null` values in the field will be replaced with the values from the replacement. In v2, at least one field is required. In v3, if no field specified, the replacement is applied to all fields. |
There was a problem hiding this comment.
remove v2 and v3, it is confuse user who does not have background.
| registerOperator(ASIN, SqlStdOperatorTable.ASIN); | ||
| registerOperator(ATAN, SqlStdOperatorTable.ATAN); | ||
| registerOperator(ATAN2, SqlStdOperatorTable.ATAN2); | ||
| registerOperator(CEIL, SqlStdOperatorTable.CEIL); |
There was a problem hiding this comment.
Yes. the ceil function is missing and it is used in CalciteFillNullCommandIT. So I added it back.
Signed-off-by: Lantao Jin <ltjin@amazon.com>
penghuo
approved these changes
May 21, 2025
qianheng-aws
approved these changes
May 21, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Support fillnull command with Calcite Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix explain IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * update doc Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fillnullcommand implemented in Add FILLNULL command in PPL (#3032) #3075 to Calcite implementation.Related Issues
Resolves #3461
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.