Skip to content

Conversation

@peterzhuamazon
Copy link
Member

Description

Remove beta1 qualifier

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit 9f881fd into opensearch-project:3.0 Apr 29, 2025
10 of 25 checks passed
@peterzhuamazon peterzhuamazon deleted the remove-beta1 branch April 29, 2025 01:23
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2025
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 9f881fd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peterzhuamazon pushed a commit that referenced this pull request Apr 29, 2025
(cherry picked from commit 9f881fd)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LantaoJin
Copy link
Member

@peterzhuamazon @zelinh this PR has compile error

@LantaoJin
Copy link
Member

LantaoJin commented Apr 29, 2025

Did it cause by cache? The compile error happens in org.opensearch.geospatial.action.IpEnrichmentActionClient where its NodeClient is still org.opensearch.client.node.NodeClient;

But the code in github is correct:
https://github.com/opensearch-project/geospatial/blob/cf67d1429994fa533fec7386d05edc461c0855e2/client/src/main/java/org/opensearch/geospatial/action/IpEnrichmentActionClient.java#L13

@LantaoJin
Copy link
Member

Did it cause by cache? The compile error happens in org.opensearch.geospatial.action.IpEnrichmentActionClient where its NodeClient is still org.opensearch.client.node.NodeClient;

But the code in github is correct: https://github.com/opensearch-project/geospatial/blob/cf67d1429994fa533fec7386d05edc461c0855e2/client/src/main/java/org/opensearch/geospatial/action/IpEnrichmentActionClient.java#L13

Issue should be addressed when opensearch-project/geospatial#750 merged and published to repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants