fix varchar bug #3518
Merged
fix varchar bug #3518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
LantaoJin
approved these changes
Apr 7, 2025
dai-chen
approved these changes
Apr 7, 2025
| executeQuery( | ||
| String.format( | ||
| "source=%s | where strict_date_optional_time > DATE_SUB(TIMESTAMP('1999-04-12" | ||
| "source=%s | where strict_date_optional_time > DATE_SUB(TIMESTAMP('1984-04-12" |
Collaborator
There was a problem hiding this comment.
Is this change related to this PR?
Contributor
Author
There was a problem hiding this comment.
Yes. It's a wrong IT. I fix it now.
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* fix varchar bug Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * fix wrong IT Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we use CHAR in some return type of udf, which will hard truncate return value. Now change it to var char.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#3400
#3520
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.