[Calcite Engine] Support UDT for IP #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
reviewed
Apr 1, 2025
| public interface ExprRelDataType extends RelDataType, RelDataTypeFamily { | ||
| ExprType getExprType(); | ||
| @Getter | ||
| public abstract class ExprRelDataType<T extends RelDataType> extends RelDataTypeImpl { |
Member
There was a problem hiding this comment.
rename to AbstractExprRelDataType
| import org.opensearch.sql.calcite.utils.OpenSearchTypeFactory; | ||
| import org.opensearch.sql.calcite.utils.OpenSearchTypeFactory.ExprUDT; | ||
|
|
||
| public class ExprSqlType extends ExprRelDataType<BasicSqlType> { |
Member
There was a problem hiding this comment.
Could you add some comments on ExprSqlType and ExprJavaType to explain why ExprDateType extends ExprSqlType but ExprIPType extends ExprJavaType
Signed-off-by: Heng Qian <qianheng@amazon.com>
Collaborator
Author
|
CI on macos/linux failed because network error: |
Member
not related failure in doctest |
LantaoJin
approved these changes
Apr 1, 2025
penghuo
approved these changes
Apr 1, 2025
Comment on lines
+36
to
+38
| public ExprType getExprType() { | ||
| return udt.getExprCoreType(); | ||
| } |
Collaborator
There was a problem hiding this comment.
it is only for backward compatible, right? we will deprecated ExprType in fugure?
Collaborator
Author
There was a problem hiding this comment.
Yeah, it doesn't need to get its correspond ExprType after deprecating ExprType. Maybe will return a UDT type name directly here.
8 tasks
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* [Calcite Engine] Support UDT for IP Signed-off-by: Heng Qian <qianheng@amazon.com> * Fix IT Signed-off-by: Heng Qian <qianheng@amazon.com> * Refine Code Signed-off-by: Heng Qian <qianheng@amazon.com> * Refine Code Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support UDT for IP, also do refactoring for ExprBasicSqlType.
Related Issues
Resolves #3395
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.