Add string builtin functions #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
|
./gradlew :integ-test:integTest --tests 'CalciteIT' succeed in local |
Signed-off-by: xinyual <xinyual@amazon.com>
LantaoJin
reviewed
Mar 7, 2025
integ-test/build.gradle
Outdated
|
|
||
| // Needed for BWC tests | ||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-job-scheduler', version: "${opensearch_build}" | ||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-job-scheduler', version:"${opensearch_build}" |
penghuo
approved these changes
Mar 7, 2025
Comment on lines
+129
to
+144
| case "LTRIM": | ||
| List<RexNode> LTrimArgs = | ||
| new ArrayList<>( | ||
| List.of( | ||
| context.rexBuilder.makeFlag(SqlTrimFunction.Flag.LEADING), | ||
| context.rexBuilder.makeLiteral(" "))); | ||
| LTrimArgs.addAll(argList); | ||
| return LTrimArgs; | ||
| case "RTRIM": | ||
| List<RexNode> RTrimArgs = | ||
| new ArrayList<>( | ||
| List.of( | ||
| context.rexBuilder.makeFlag(SqlTrimFunction.Flag.TRAILING), | ||
| context.rexBuilder.makeLiteral(" "))); | ||
| RTrimArgs.addAll(argList); | ||
| return RTrimArgs; |
There was a problem hiding this comment.
nit, Calcite defined RTRIM and LTRIM , could we consider reuse it in future?
There was a problem hiding this comment.
In our current implementation, we will use the RexCallImplementor in https://github.com/apache/calcite/blob/48648b391367eeb7910e934cc73dabbe1d7370c0/core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java#L1416, and the ltrim and rtrim is not actually defined in the RexImpTable. So these two functions are not suitable for our current implementation. But we could track them and see whether we could change our logic to reuse them.
Signed-off-by: xinyual <xinyual@amazon.com>
LantaoJin
merged commit b7f6cf7
into
opensearch-project:feature/calcite-engine
4 of 13 checks passed
penghuo
pushed a commit
to penghuo/os-sql
that referenced
this pull request
Mar 12, 2025
* add string udfs Signed-off-by: xinyual <xinyual@amazon.com> * add it to string Signed-off-by: xinyual <xinyual@amazon.com> * add IT for string function Signed-off-by: xinyual <xinyual@amazon.com> * remove change for local test Signed-off-by: xinyual <xinyual@amazon.com> * revert change Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* add string udfs Signed-off-by: xinyual <xinyual@amazon.com> * add it to string Signed-off-by: xinyual <xinyual@amazon.com> * add IT for string function Signed-off-by: xinyual <xinyual@amazon.com> * remove change for local test Signed-off-by: xinyual <xinyual@amazon.com> * revert change Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr add string builtin functions with corresponding IT. Some ITs are mapped from spark, others are written by ourseleves
Related Issues
Resolves #3399
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.