Implement ppl scalar subquery command with Calcite #3392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
qianheng-aws
reviewed
Mar 7, 2025
| if (expr instanceof Compare c) { | ||
| return containsScalarSubquery(c.getLeft()) || containsScalarSubquery(c.getRight()); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Should we support more cases than Not, Let and Compare?
There was a problem hiding this comment.
Sure, addressed in latest commit, please check it again
Signed-off-by: Lantao Jin <ltjin@amazon.com>
qianheng-aws
reviewed
Mar 7, 2025
|
|
||
| private boolean containsExistsSubquery(Object condition) { | ||
| if (condition instanceof ExistsSubquery) { | ||
| private boolean containsExistsSubquery(Node expr) { |
There was a problem hiding this comment.
How about combining this 2 flags together? Will we use them separately in specific cases?
Signed-off-by: Lantao Jin <ltjin@amazon.com>
qianheng-aws
approved these changes
Mar 7, 2025
|
Merging to dev branch to unblock others, cc @penghuo to async review. |
LantaoJin
merged commit a07c2cd
into
opensearch-project:feature/calcite-engine
4 of 13 checks passed
penghuo
pushed a commit
to penghuo/os-sql
that referenced
this pull request
Mar 12, 2025
…t#3392) * Implement ppl scalar subquery command with Calcite Signed-off-by: Lantao Jin <ltjin@amazon.com> * more general subquery checker Signed-off-by: Lantao Jin <ltjin@amazon.com> * support correlated IN subquery Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Implement ppl scalar subquery command with Calcite Signed-off-by: Lantao Jin <ltjin@amazon.com> * more general subquery checker Signed-off-by: Lantao Jin <ltjin@amazon.com> * support correlated IN subquery Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core Syntax: Implement ppl scalar subquery command with Calcite
All unit tests in
ppl/src/test/java/org/opensearch/sql/ppl/calcitesucceed in local./gradlew :integ-test:integTest --tests '*Calcite*IT'succeed in localRelated Issues
Resolves #3361
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.