Fix CalcitePPLJoinIT #3369
Merged
Fix CalcitePPLJoinIT #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <qianheng@amazon.com>
…t type Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Mar 3, 2025
| "type": "keyword" | ||
| }, | ||
| "occupation": { | ||
| "type": "text" |
There was a problem hiding this comment.
@qianheng-aws , please create an issue of supporting text type pushdown. I will add it as child of #3309. Note, the new issue may not require product code change since it could be a part of adding external property to Calcite plan. But at least we need to add some tests to verify the text (may include more) type code be pushdown.
There was a problem hiding this comment.
We already have a issue to fix text push down, #3334
There was a problem hiding this comment.
Please add this issue as a subtask of that as well, #3370
|
Merging to dev branch firstly. cc @penghuo |
LantaoJin
merged commit e2d7333
into
opensearch-project:feature/calcite-engine
6 of 14 checks passed
penghuo
pushed a commit
to penghuo/os-sql
that referenced
this pull request
Mar 12, 2025
* Fix PredicateAnalyzer for in and notIn Signed-off-by: Heng Qian <qianheng@amazon.com> * Change text field to keyword since we don't support push down for that type Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com>
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Fix PredicateAnalyzer for in and notIn Signed-off-by: Heng Qian <qianheng@amazon.com> * Change text field to keyword since we don't support push down for that type Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes 2 changes:
./gradlew :integ-test:integTest --tests '*Calcite*IT'succeed locally except below 3 tests. They failed because of inconsistent order on the final results while it should not promise that order. Need another PR to fix the test themself.Related Issues
Resolves #3368
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.