Skip to content

Conversation

@andy-k-improving
Copy link
Contributor

@andy-k-improving andy-k-improving commented Jan 21, 2025

Description

Missing close curly brace on datasource-prmetheus.md which result in Jeykll build fail at the moment on main branch.

https://github.com/opensearch-project/sql/actions/runs/12890965970/job/35941801363

image

Related Issues

Partial resolves: #3168

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andy Kwok <andy.kwok@improving.com>
@andy-k-improving
Copy link
Contributor Author

@YANG-DB Should be a quick-one, however this can only be tested on main branch.

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch ...

@YANG-DB YANG-DB merged commit b738faf into opensearch-project:main Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Get well plan for the Github CI pipeline

3 participants