generated from amazon-archives/__template_Custom
-
Couldn't load subscription status.
- Fork 176
Support for OpenSearch alias type #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| {"index":{"_id":"1"}} | ||
| {"original_col" : 1} | ||
| {"index":{"_id":"2"}} | ||
| {"original_col" : 2} | ||
| {"index":{"_id":"3"}} | ||
| {"original_col" : 3} |
13 changes: 13 additions & 0 deletions
13
integ-test/src/test/resources/indexDefinitions/alias_index_mapping.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "mappings": { | ||
| "properties": { | ||
| "original_col": { | ||
| "type": "integer" | ||
| }, | ||
| "alias_col": { | ||
| "type": "alias", | ||
| "path": "original_col" | ||
| } | ||
| } | ||
| } | ||
| } |
83 changes: 83 additions & 0 deletions
83
opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchAliasType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.opensearch.sql.opensearch.data.type; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import org.opensearch.sql.data.type.ExprType; | ||
|
|
||
| /** | ||
| * The type of alias. See <a | ||
| * href="https://opensearch.org/docs/latest/opensearch/supported-field-types/alias/">doc</a> | ||
| */ | ||
| public class OpenSearchAliasType extends OpenSearchDataType { | ||
penghuo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| public static final String typeName = "alias"; | ||
| public static final String pathPropertyName = "path"; | ||
| public static final Set<MappingType> objectFieldTypes = | ||
| Set.of(MappingType.Object, MappingType.Nested); | ||
| private final String path; | ||
| private final OpenSearchDataType originalType; | ||
|
|
||
| public OpenSearchAliasType(String path, OpenSearchDataType type) { | ||
| super(type.getExprCoreType()); | ||
| if (type instanceof OpenSearchAliasType) { | ||
| throw new IllegalStateException( | ||
| String.format("Alias field cannot refer to the path [%s] of alias type", path)); | ||
| } else if (objectFieldTypes.contains(type.getMappingType())) { | ||
| throw new IllegalStateException( | ||
| String.format("Alias field cannot refer to the path [%s] of object type", path)); | ||
| } | ||
| this.path = path; | ||
| this.originalType = type; | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<String> getOriginalPath() { | ||
| return Optional.of(this.path); | ||
| } | ||
|
|
||
| @Override | ||
| public ExprType getOriginalExprType() { | ||
| return originalType.getExprType(); | ||
| } | ||
|
|
||
| @Override | ||
| public ExprType getExprType() { | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public OpenSearchDataType cloneEmpty() { | ||
| return new OpenSearchAliasType(this.path, originalType.cloneEmpty()); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isCompatible(ExprType other) { | ||
| return originalType.isCompatible(other); | ||
| } | ||
|
|
||
| @Override | ||
| public List<ExprType> getParent() { | ||
| return originalType.getParent(); | ||
| } | ||
|
|
||
| @Override | ||
| public String typeName() { | ||
| return originalType.typeName(); | ||
| } | ||
|
|
||
| @Override | ||
| public String legacyTypeName() { | ||
| return originalType.legacyTypeName(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean shouldCast(ExprType other) { | ||
| return originalType.shouldCast(other); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.