Add MacOS workflows back and fix the artifact not found issue #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
rupal-bq,
seankao-az,
vamsimanohar and
ykmr1224
as code owners
Member
Author
Collaborator
|
@LantaoJin thanks. My main reasoning for removing it is macos is not officially supported distribution of opensearch, so I don't see much point in running CI checks against it, and is throwing away github runner resources, but I won't block the PR/if OS core is doing it I don't see much harm in doing it as well. |
derek-ho
approved these changes
Jul 16, 2024
ykmr1224
approved these changes
Jul 16, 2024
LantaoJin
added a commit
that referenced
this pull request
Jul 17, 2024
manasvinibs
pushed a commit
to manasvinibs/sql
that referenced
this pull request
Aug 14, 2024
…rch-project#2831) Signed-off-by: Lantao Jin <ltjin@amazon.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
…rch-project#2831) Signed-off-by: Lantao Jin <ltjin@amazon.com>
This was referenced Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MacOS build workflows were removed in #2662 because we don't have the M series artifacts. This PR addresses the artifact not found problem via replace
macos-latestbymacos-13.macos-13is the MacOS version used in workflows of OpenSearch Core:Issues Resolved
workflow failure
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.