Skip to content

Scaffold async-query-core and async-query module #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ykmr1224 merged 1 commit into from
Jun 11, 2024
Merged

Scaffold async-query-core and async-query module #2733

ykmr1224 merged 1 commit into from
Jun 11, 2024

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 10, 2024

Description

  • Scaffold async-query-core and async-query module.
    • async-query-core will include the core logic async-query without OpenSearch specific implementations
    • async-query will include OpenSearch specific part such as data accessor using OpenSearch index.
  • There are dummy classes and its tests to verify the dependency/build works. Those will be deleted when actual classes are moved from spark module in the next PR. (separated it to reduce the size of PR)

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Jun 10, 2024
@ykmr1224 ykmr1224 force-pushed the dqs/async-query-core branch 2 times, most recently from 7b2348e to 3a77824 Compare June 10, 2024 20:11
@ykmr1224
Scaffold async-query-core and async-query module
ea8d388 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 force-pushed the dqs/async-query-core branch from 3a77824 to ea8d388 Compare June 10, 2024 22:01
@ykmr1224 ykmr1224 marked this pull request as ready for review June 10, 2024 23:46
vamsimanohar
vamsimanohar reviewed Jun 11, 2024
View reviewed changes
vamsimanohar
vamsimanohar reviewed Jun 11, 2024
View reviewed changes
@ykmr1224 ykmr1224 merged commit 46015d4 into opensearch-project:main Jun 11, 2024
@ykmr1224 ykmr1224 deleted the dqs/async-query-core branch June 12, 2024 22:16
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 13, 2024
@ykmr1224
Scaffold async-query-core and async-query module (opensearch-project#…
2fc8aff 
…2733)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

(cherry picked from commit 46015d4)
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 13, 2024
@ykmr1224
Scaffold async-query-core and async-query module (opensearch-project#…
fbebd7f 
…2733)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 46015d4)
@ykmr1224 ykmr1224 mentioned this pull request Jun 13, 2024
Merged
6 tasks
ykmr1224 added a commit that referenced this pull request Jun 13, 2024
@ykmr1224
Scaffold async-query-core and async-query module (#2733) (#2751)
f1523d5 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 46015d4)
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
@ykmr1224 @jzonthemtn
Scaffold async-query-core and async-query module (opensearch-project#…
8c882c2 
…2733)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vamsimanohar vamsimanohar vamsimanohar approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

+1 more reviewer

@rupal-bq rupal-bq rupal-bq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 2.x maintenance Improves code quality, but not the product

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ykmr1224 @rupal-bq @vamsimanohar