Skip to content

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 4, 2024

Description

  • Add accountId to data models to make it extensible to use multiple accountIds for EMR-S

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Copy link
Contributor

@rupal-bq rupal-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykmr1224 ykmr1224 force-pushed the dqs/add-account-id branch from 34e6160 to c8812c9 Compare June 5, 2024 20:09
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Jun 5, 2024
@ykmr1224 ykmr1224 merged commit ffc48fa into opensearch-project:main Jun 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit ffc48fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jun 7, 2024
(cherry picked from commit ffc48fa)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ykmr1224 ykmr1224 deleted the dqs/add-account-id branch June 12, 2024 22:16
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x maintenance Improves code quality, but not the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants