Skip to content

Conversation

@ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented May 9, 2024

Description

Extract SessionStorageService and StatementStorageService so that it can be used with other storage.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ykmr1224 added 2 commits May 9, 2024 16:00
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
rupal-bq
rupal-bq previously approved these changes May 10, 2024
Copy link
Contributor

@rupal-bq rupal-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes! Also please add copyright in TestEMRServerlessClient, SessionTestUtil, StatementStorageService, OpenSearchStatementStorageService, OpenSearchSessionStorageService.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
seankao-az
seankao-az previously approved these changes May 13, 2024
@vamsimanohar
Copy link
Member

Please ensure build issues are not because of this PR.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (df1c04a) to head (8c195ae).
Report is 3 commits behind head on main.

❗ Current head 8c195ae differs from pull request most recent head 970b551. Consider uploading reports for the commit 970b551 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2665      +/-   ##
============================================
+ Coverage     95.24%   95.29%   +0.05%     
+ Complexity     5084     5079       -5     
============================================
  Files           486      488       +2     
  Lines         14269    14253      -16     
  Branches        952      952              
============================================
- Hits          13591    13583       -8     
+ Misses          653      645       -8     
  Partials         25       25              
Flag Coverage Δ
sql-engine 95.29% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 merged commit 1985459 into opensearch-project:main May 15, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2665-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1985459b7979ca6d1d9cae0b2c04851e6657f5af
# Push it to GitHub
git push --set-upstream origin backport/backport-2665-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2665-to-2.x.

ykmr1224 added a commit to ykmr1224/sql that referenced this pull request May 15, 2024
…-project#2665)

* Extract SessionStorageService and StatementStorageService

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Reformat

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Add copyright comment

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Add comments and remove unused methods

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Remove unneeded imports

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Fix code format issue

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 1985459)
@ykmr1224 ykmr1224 deleted the dqs/refactor-session branch May 15, 2024 21:04
ykmr1224 added a commit that referenced this pull request May 16, 2024
* Extract SessionStorageService and StatementStorageService

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Reformat

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Add copyright comment

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Add comments and remove unused methods

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Remove unneeded imports

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

* Fix code format issue

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>

---------

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 1985459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x backport-failed maintenance Improves code quality, but not the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants