-
Notifications
You must be signed in to change notification settings - Fork 181
Extract SessionStorageService and StatementStorageService #2665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract SessionStorageService and StatementStorageService #2665
Conversation
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
rupal-bq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the changes! Also please add copyright in TestEMRServerlessClient, SessionTestUtil, StatementStorageService, OpenSearchStatementStorageService, OpenSearchSessionStorageService.
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
spark/src/main/java/org/opensearch/sql/spark/execution/statestore/StatementStorageService.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/execution/statestore/StatementStorageService.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/execution/session/SessionManager.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/execution/statestore/StateStore.java
Outdated
Show resolved
Hide resolved
|
Please ensure build issues are not because of this PR. |
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
============================================
+ Coverage 95.24% 95.29% +0.05%
+ Complexity 5084 5079 -5
============================================
Files 486 488 +2
Lines 14269 14253 -16
Branches 952 952
============================================
- Hits 13591 13583 -8
+ Misses 653 645 -8
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2665-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1985459b7979ca6d1d9cae0b2c04851e6657f5af
# Push it to GitHub
git push --set-upstream origin backport/backport-2665-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
…-project#2665) * Extract SessionStorageService and StatementStorageService Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Reformat Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Add copyright comment Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Add comments and remove unused methods Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Remove unneeded imports Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix code format issue Signed-off-by: Tomoyuki Morita <moritato@amazon.com> --------- Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 1985459)
* Extract SessionStorageService and StatementStorageService Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Reformat Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Add copyright comment Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Add comments and remove unused methods Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Remove unneeded imports Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix code format issue Signed-off-by: Tomoyuki Morita <moritato@amazon.com> --------- Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 1985459)
Description
Extract SessionStorageService and StatementStorageService so that it can be used with other storage.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.