Fix semicolon parsing for async query #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48,
rupal-bq and
vamsimanohar
as code owners
seankao-az
changed the title
YANG-DB
previously approved these changes
Apr 20, 2024
Signed-off-by: Sean Kao <seankao@amazon.com>
noCharger
approved these changes
Apr 21, 2024
Collaborator
noCharger
left a comment
noCharger
left a comment
There was a problem hiding this comment.
Thanks for the change!
dai-chen
reviewed
Apr 22, 2024
| | DELETE FROM identifierReference tableAlias whereClause? #deleteFromTable | ||
| | UPDATE identifierReference tableAlias setClause whereClause? #updateTable | ||
| | MERGE INTO target=identifierReference targetAlias=tableAlias | ||
| | MERGE (WITH SCHEMA EVOLUTION)? INTO target=identifierReference targetAlias=tableAlias |
Collaborator
There was a problem hiding this comment.
This is latest changes from Spark 3.3.1 grammar?
vamsimanohar
approved these changes
Apr 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* update sql grammar files from upstream Signed-off-by: Sean Kao <seankao@amazon.com> * resolve semicolon cause incorrect parsing Signed-off-by: Sean Kao <seankao@amazon.com> * spotlessApply Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> (cherry picked from commit 7f8fbe9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Apr 22, 2024
* update sql grammar files from upstream * resolve semicolon cause incorrect parsing * spotlessApply --------- (cherry picked from commit 7f8fbe9) Signed-off-by: Sean Kao <seankao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue of no streaming job when
CREATE MATERIALIZED VIEWstatement ends with a semicolon.Align parsing with upstream
opensearch-sparkrepo:https://github.com/opensearch-project/opensearch-spark/blob/b5ab7bd3ed135f1827df2cb0ca17422beb776985/flint-spark-integration/src/main/scala/org/opensearch/flint/spark/sql/FlintSparkSqlParser.scala#L58
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.