Skip to content

Throw OpensearchSecurityException incase of datasource authorization … #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vamsimanohar merged 1 commit into from
Apr 22, 2024
Merged

Throw OpensearchSecurityException incase of datasource authorization … #2626

vamsimanohar merged 1 commit into from
Apr 22, 2024

Conversation

@vamsimanohar
Copy link
Member

@vamsimanohar vamsimanohar commented Apr 18, 2024 •
edited
Loading

Description

Throw OpensearchSecurityException in case of datasource authorization error. Today we are throwing SecurityException from java and it is resulting in 500 error. With this change we are throwing OpensearchSecurityException with 403 as error code.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsimanohar
Throw OpensearchSecurityException incase of datasource authorization …
ede02d2 
…error

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vamsimanohar vamsimanohar marked this pull request as ready for review April 18, 2024 03:39
noCharger
noCharger approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vamsimanohar vamsimanohar self-assigned this Apr 18, 2024
@vamsimanohar vamsimanohar added bug Something isn't working backport 2.x labels Apr 18, 2024
@vamsimanohar vamsimanohar merged commit 5464bfc into opensearch-project:main Apr 22, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@github-actions
Throw OpensearchSecurityException incase of datasource authorization …
8c68aa0 
…error (#2626)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 5464bfc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 22, 2024
Merged
vamsimanohar pushed a commit that referenced this pull request Apr 22, 2024
@opensearch-trigger-bot @github-actions
Throw OpensearchSecurityException incase of datasource authorization …
bce7758 
…error (#2626) (#2634)

(cherry picked from commit 5464bfc)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48 ps48 ps48 approved these changes

@noCharger noCharger noCharger approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

+1 more reviewer

@rupal-bq rupal-bq rupal-bq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vamsimanohar vamsimanohar

Labels

backport 2.x bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vamsimanohar @ps48 @noCharger @rupal-bq