Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue datasource support #2055

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Sep 7, 2023

Description

Testing:

curl --location 'http://localhost:9200/_plugins/_query/_datasources' \
--header 'Content-Type: application/json' \
--data '{
    "name" : "my_glue",
    "connector" : "glue",
    "properties" : {
           "glue.auth.type": "iam_role",
    "glue.auth.account_id": "access_key",
    "glue.auth.role_arn": "role_arn",
    "glue.auth.region": "region",    
    "emr.datasource.flint.uri": "http://localhost:9200",
    "emr.datasource.flint.auth" :"false",
    "emr.datasource.flint.region": "us-west-2"
    }
}'

Response:

Created DataSource with name my_glue

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2055 (ff52688) into feature/job-apis (61d1eb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##             feature/job-apis    #2055   +/-   ##
===================================================
  Coverage               97.27%   97.27%           
- Complexity               4623     4627    +4     
===================================================
  Files                     410      411    +1     
  Lines                   11947    11961   +14     
  Branches                  828      828           
===================================================
+ Hits                    11621    11635   +14     
  Misses                    317      317           
  Partials                    9        9           
Flag Coverage Δ
sql-engine 97.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ch/sql/datasources/glue/GlueDataSourceFactory.java 100.00% <100.00%> (ø)
...l/datasources/utils/DatasourceValidationUtils.java 93.33% <100.00%> (ø)

@vamsi-amazon vamsi-amazon force-pushed the datasource-glue-support branch 3 times, most recently from 5e488f5 to 7304956 Compare September 8, 2023 22:04
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon merged commit dae6dc3 into opensearch-project:feature/job-apis Sep 9, 2023
10 of 19 checks passed
vamsi-amazon added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon added a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Add tags to the emr jobs based on the query types (#2150)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Add tags to the emr jobs based on the query types (#2150)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit ae10857)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Sep 27, 2023
* Glue datasource support (#2055)



* Initial commit of new job APIs (#2050)



* Create Job API (#2070)

* Create Job API



* Refactor to Async Query API



---------



* Cancel Job API (#2126)



* Add tags to the emr jobs based on the query types (#2150)



---------


(cherry picked from commit ae10857)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Fix response codes returned

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove @opensearch datasource, update with new type

Signed-off-by: Derek Ho <dxho@amazon.com>

* Spotless Apply

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Revert change back to json string

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update tests to use JSON string literal instead of formatting

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix show datsources IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove files from merge

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Initial commit of new job APIs (#2050)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Create Job API (#2070)

* Create Job API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Refactor to Async Query API

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Cancel Job API (#2126)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Fix response codes returned

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove @opensearch datasource, update with new type

Signed-off-by: Derek Ho <dxho@amazon.com>

* Spotless Apply

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix tests

Signed-off-by: Derek Ho <dxho@amazon.com>

* Revert change back to json string

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update tests to use JSON string literal instead of formatting

Signed-off-by: Derek Ho <dxho@amazon.com>

* Update IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Fix show datsources IT

Signed-off-by: Derek Ho <dxho@amazon.com>

* Remove files from merge

Signed-off-by: Derek Ho <dxho@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 5ce1bab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Oct 3, 2023
* Glue datasource support (#2055)



* Initial commit of new job APIs (#2050)



* Create Job API (#2070)

* Create Job API



* Refactor to Async Query API



---------



* Cancel Job API (#2126)



* Fix response codes returned



* Remove @opensearch datasource, update with new type



* Spotless Apply



* Fix tests



* Revert change back to json string



* Update tests to use JSON string literal instead of formatting



* Update IT



* Fix show datsources IT



* Remove files from merge



---------




(cherry picked from commit 5ce1bab)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants