-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glue datasource support #2055
Merged
vamsi-amazon
merged 1 commit into
opensearch-project:feature/job-apis
from
vamsi-amazon:datasource-glue-support
Sep 9, 2023
Merged
Glue datasource support #2055
vamsi-amazon
merged 1 commit into
opensearch-project:feature/job-apis
from
vamsi-amazon:datasource-glue-support
Sep 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/job-apis #2055 +/- ##
===================================================
Coverage 97.27% 97.27%
- Complexity 4623 4627 +4
===================================================
Files 410 411 +1
Lines 11947 11961 +14
Branches 828 828
===================================================
+ Hits 11621 11635 +14
Misses 317 317
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vamsi-amazon
force-pushed
the
datasource-glue-support
branch
3 times, most recently
from
September 8, 2023 06:28
8c0a933
to
a5a54e0
Compare
vamsi-amazon
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
September 8, 2023 06:53
penghuo
reviewed
Sep 8, 2023
common/src/main/java/org/opensearch/sql/common/setting/Settings.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/datasource/model/DataSourceType.java
Outdated
Show resolved
Hide resolved
datasources/src/main/java/org/opensearch/sql/datasources/glue/GlueDatasourceFactory.java
Outdated
Show resolved
Hide resolved
datasources/src/main/java/org/opensearch/sql/datasources/glue/GlueDatasourceFactory.java
Outdated
Show resolved
Hide resolved
datasources/src/main/java/org/opensearch/sql/datasources/glue/GlueDatasourceFactory.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Sep 8, 2023
datasources/src/main/java/org/opensearch/sql/datasources/glue/GlueDatasourceFactory.java
Outdated
Show resolved
Hide resolved
datasources/src/main/java/org/opensearch/sql/datasources/glue/GlueDatasourceFactory.java
Outdated
Show resolved
Hide resolved
vamsi-amazon
force-pushed
the
datasource-glue-support
branch
3 times, most recently
from
September 8, 2023 22:04
5e488f5
to
7304956
Compare
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
force-pushed
the
datasource-glue-support
branch
from
September 8, 2023 22:08
7304956
to
ff52688
Compare
penghuo
approved these changes
Sep 8, 2023
vamsi-amazon
merged commit Sep 9, 2023
dae6dc3
into
opensearch-project:feature/job-apis
10 of 19 checks passed
vamsi-amazon
added a commit
that referenced
this pull request
Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
added a commit
that referenced
this pull request
Sep 22, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
added a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit ae10857) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) * Initial commit of new job APIs (#2050) * Create Job API (#2070) * Create Job API * Refactor to Async Query API --------- * Cancel Job API (#2126) * Add tags to the emr jobs based on the query types (#2150) --------- (cherry picked from commit ae10857) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Fix response codes returned Signed-off-by: Derek Ho <dxho@amazon.com> * Remove @opensearch datasource, update with new type Signed-off-by: Derek Ho <dxho@amazon.com> * Spotless Apply Signed-off-by: Derek Ho <dxho@amazon.com> * Fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * Revert change back to json string Signed-off-by: Derek Ho <dxho@amazon.com> * Update tests to use JSON string literal instead of formatting Signed-off-by: Derek Ho <dxho@amazon.com> * Update IT Signed-off-by: Derek Ho <dxho@amazon.com> * Fix show datsources IT Signed-off-by: Derek Ho <dxho@amazon.com> * Remove files from merge Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Fix response codes returned Signed-off-by: Derek Ho <dxho@amazon.com> * Remove @opensearch datasource, update with new type Signed-off-by: Derek Ho <dxho@amazon.com> * Spotless Apply Signed-off-by: Derek Ho <dxho@amazon.com> * Fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * Revert change back to json string Signed-off-by: Derek Ho <dxho@amazon.com> * Update tests to use JSON string literal instead of formatting Signed-off-by: Derek Ho <dxho@amazon.com> * Update IT Signed-off-by: Derek Ho <dxho@amazon.com> * Fix show datsources IT Signed-off-by: Derek Ho <dxho@amazon.com> * Remove files from merge Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 5ce1bab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Oct 3, 2023
* Glue datasource support (#2055) * Initial commit of new job APIs (#2050) * Create Job API (#2070) * Create Job API * Refactor to Async Query API --------- * Cancel Job API (#2126) * Fix response codes returned * Remove @opensearch datasource, update with new type * Spotless Apply * Fix tests * Revert change back to json string * Update tests to use JSON string literal instead of formatting * Update IT * Fix show datsources IT * Remove files from merge --------- (cherry picked from commit 5ce1bab) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing:
Response:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.