[Backport 2.x] Add _primary preference only for segment replication enabled indices #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…2040) * Add _primary preference only for segment replication enabled indices Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add test for segment replication tests Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove isSegRepEnabled check and use _primary_first preference Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove unused ClusterState reference Signed-off-by: Suraj Singh <surajrider@gmail.com> * Self review Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 9c12628) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
dreamer-89
approved these changes
Sep 1, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #2045 +/- ##
=========================================
Coverage 97.32% 97.32%
Complexity 4661 4661
=========================================
Files 410 410
Lines 12109 12110 +1
Branches 831 831
=========================================
+ Hits 11785 11786 +1
Misses 317 317
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@penghuo @vamsi-amazon : Need help with review and merge on this. |
penghuo
approved these changes
Sep 1, 2023
vamsi-amazon
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9c12628 from #2040.