Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checkstyle version #1945

Closed
wants to merge 1 commit into from

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Aug 9, 2023

Description

Updated checkstyle version to fix CVE

Issues Resolved

#1767

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1945 (95c68c7) into main (3db0d4f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1945   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4646     4646           
=========================================
  Files           408      408           
  Lines         11549    11549           
  Branches        838      838           
=========================================
  Hits          11252    11252           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Yury-Fridlyand
Copy link
Collaborator

  1. It has a conflict with a dependency
  2. It is not needed, since we will remove checkstyle soon

@GumpacG
Copy link
Collaborator Author

GumpacG commented Aug 9, 2023

Sounds good. Closing this. Ignore whitesource error for now.

@GumpacG GumpacG closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants