Guarantee datasource read api is strong consistent read #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
dai-chen
approved these changes
Jul 7, 2023
joshuali925
approved these changes
Jul 7, 2023
rupal-bq
approved these changes
Jul 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit f38ffed)
penghuo
added a commit
that referenced
this pull request
Jul 10, 2023
dreamer-89
reviewed
Jul 12, 2023
| @@ -217,6 +217,8 @@ private List<DataSourceMetadata> searchInDataSourcesIndex(QueryBuilder query) { | |||
| searchSourceBuilder.query(query); | |||
| searchSourceBuilder.size(DATASOURCE_QUERY_RESULT_SIZE); | |||
| searchRequest.source(searchSourceBuilder); | |||
| // strongly consistent reads is requred. more info https://github.com/opensearch-project/sql/issues/1801. | |||
| searchRequest.preference("_primary"); | |||
There was a problem hiding this comment.
@penghuo : Is there any data around TPS requirement for this search query ? I am thinking if this can have any performance implications for an overwhelmed primary shard.
dreamer-89
added a commit
to dreamer-89/sql
that referenced
this pull request
Aug 22, 2023
…search-project#1815)" This reverts commit f38ffed.
dreamer-89
added a commit
to dreamer-89/sql
that referenced
this pull request
Aug 22, 2023
…search-project#1815)" This reverts commit f38ffed. Signed-off-by: Suraj Singh <surajrider@gmail.com>
MaxKsyunz
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will add IT later because current IT RestTestIT does not support configure nodes for each test and I do not want to configure nodes for all the IT now which will be also risky.
Create an issue for impove IT framework.#1816
Issues Resolved
#1801
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.