Skip to content

[Backport 2.x] Fix null response from pow/power and added missing integration testing #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yury-Fridlyand merged 1 commit into from
Mar 22, 2023
Merged

[Backport 2.x] Fix null response from pow/power and added missing integration testing #1459

Yury-Fridlyand merged 1 commit into from
Mar 22, 2023

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Mar 21, 2023

Backport a35f963 from #1457

@matthewryanwells @github-actions
Added missing integration tests for the pow and power functions (#247) (
c973902 
#1457)

* Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function.

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit a35f963)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 21, 2023 22:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (5cfa702) to head (c973902).
⚠️ Report is 376 commits behind head on 2.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##                2.x    #1459   +/-   ##
=========================================
  Coverage     98.46%   98.46%           
- Complexity     3844     3848    +4     
=========================================
  Files           345      345           
  Lines          9550     9554    +4     
  Branches        613      615    +2     
=========================================
+ Hits           9403     9407    +4     
  Misses          142      142           
  Partials          5        5
Flag Coverage Δ
sql-engine 98.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dai-chen dai-chen added the enhancement New feature or request label Mar 22, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 49a82ae into 2.x Mar 22, 2023
@github-actions github-actions bot deleted the backport/backport-1457-to-2.x branch March 22, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dai-chen dai-chen dai-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codecov-commenter @dai-chen @Yury-Fridlyand @matthewryanwells