Skip to content

Conversation

@matthewryanwells
Copy link
Contributor

Description

Updated SINH function to V2 engine, added documentation, unit/IT tests

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 22:09
@dai-chen dai-chen merged commit c9f96fb into opensearch-project:main Mar 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit c9f96fb)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 15, 2023
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit c9f96fb)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants