Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop into main #142

Merged
merged 15 commits into from
Jun 26, 2021
Merged

Merge develop into main #142

merged 15 commits into from
Jun 26, 2021

Conversation

davidcui1225
Copy link
Contributor

Description

Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

penghuo and others added 8 commits June 8, 2021 14:39
@penghuo
Support construct AggregationResponseParser during Aggregator build s…
b39e7b6 
…tage (#108)

* Support construct AggregationResponseParser during Aggregator build stage

* modify the doc

Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo
Impl stddev and variance function in SQL and PPL (#115)
8632f80 
* impl variance frontend and backend

* Support construct AggregationResponseParser during Aggregator build stage

* add var and varp for PPL

Signed-off-by: penghuo <penghuo@gmail.com>

* add UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix doc format

Signed-off-by: penghuo <penghuo@gmail.com>

* fix the doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add stddev_samp and stddev_pop

Signed-off-by: penghuo <penghuo@gmail.com>

* fix UT coverage

* address comments

Signed-off-by: penghuo <penghuo@gmail.com>
@chloe-zh
Fix the aggregation filter missing in named aggregators (#123)
9ff2793 
* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* Added test case where filtered agg is not pushed down

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>

* update

Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@zhongnansu
Rename gradle tasks in the manner of Opensearch (#133)
70af5bd 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
@davidcui1225
add testing-library/user-event to pass CI (#141)
2025fa9 
Signed-off-by: David Cui <davidcui@amazon.com>
@penghuo
Deprecated legacy settings instead of removing (#140)
51864a2 
* Deprecated cursor enabling and fetch size setting

Signed-off-by: penghuo <penghuo@gmail.com>

* update doc

Signed-off-by: penghuo <penghuo@gmail.com>

* add more deprecated settings

Signed-off-by: penghuo <penghuo@gmail.com>
@davidcui1225
Add Codecov to SQL (#138)
b7f8060 
* add codecov to CI workflow

Signed-off-by: David Cui <davidcui@amazon.com>

* add codecov token
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225 @dependabot
Add Docs and link checker workflow (#139)
d513f79 
* save progress on doc renaming

* update rest of documentation links
Signed-off-by: David Cui <davidcui@amazon.com>

* add workbench developer guide and update readme
Signed-off-by: David Cui <davidcui@amazon.com>

* Bump glob-parent from 5.1.1 to 5.1.2 in /workbench

Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* add testing-library
Signed-off-by: David Cui <davidcui@amazon.com>

* rename workbench artifact name to kebab case
Signed-off-by: David Cui <davidcui@amazon.com>

* standardize maintainers list based on team roles, fix workbench name in dev guide
Signed-off-by: David Cui <davidcui@amazon.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@94a059a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   99.89%           
  Complexity      ?     2471           
=======================================
  Files           ?      245           
  Lines           ?     5748           
  Branches        ?      333           
=======================================
  Hits            ?     5742           
  Misses          ?        5           
  Partials        ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a059a...692f514. Read the comment docs.

@chloe-zh
Copy link
Contributor

chloe-zh commented Jun 25, 2021 •
edited
Loading

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think

@joshuali925
Copy link
Member

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

@chloe-zh
Copy link
Contributor

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.

chloe-zh
chloe-zh approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the link checker is fixed. Thanks!

@davidcui1225
add links to exclude from link checker
29d26c7 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix localhost exclusion flag
9a6021b 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
add all exclusion links, revert localhost exclusion away from regex
a8b1c03 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix family.zzz exclusion, remove stale link from odbc sign_installers
e7b0aa6 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
fix lychee workflow after local testing and replace old sign_installe…
2e0edfa 
…rs url

Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225
remove accidental duplicate exclude flag
68fd7f4 
Signed-off-by: David Cui <davidcui@amazon.com>
penghuo
penghuo approved these changes Jun 26, 2021
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@davidcui1225
remove sign installers as it is out of date
692f514 
Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225 davidcui1225 merged commit 254510e into main Jun 26, 2021
@davidcui1225 davidcui1225 deleted the develop branch June 26, 2021 00:47
@acarbonetto acarbonetto mentioned this pull request Nov 3, 2022
Open
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Feb 2, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@penghuo penghuo penghuo approved these changes

@chloe-zh chloe-zh chloe-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidcui1225 @codecov-commenter @chloe-zh @joshuali925 @penghuo @zhongnansu