Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix ArgumentCaptor can't capture varargs (#1320) #1322

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Feb 3, 2023

Signed-off-by: Peng Huo penghuo@gmail.com
(cherry picked from commit 513428b)

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix ArgumentCaptor can't capture varargs

Signed-off-by: Peng Huo <penghuo@gmail.com>

* bump bwc version to 2.6.0

Signed-off-by: Peng Huo <penghuo@gmail.com>

---------

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 513428b)
@penghuo penghuo requested a review from a team as a code owner February 3, 2023 22:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #1322 (c3afb94) into 2.x (3e60ad3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #1322      +/-   ##
============================================
+ Coverage     98.35%   98.37%   +0.01%     
- Complexity     3610     3645      +35     
============================================
  Files           346      345       -1     
  Lines          8944     9022      +78     
  Branches        562      585      +23     
============================================
+ Hits           8797     8875      +78     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rage/querybuilder/SeriesSelectionQueryBuilder.java 100.00% <100.00%> (ø)
...rage/querybuilder/TimeRangeParametersResolver.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <0.00%> (ø)
.../java/org/opensearch/sql/data/model/ExprValue.java 100.00% <0.00%> (ø)
...ava/org/opensearch/sql/data/type/ExprCoreType.java 100.00% <0.00%> (ø)
...a/org/opensearch/sql/data/model/ExprDateValue.java 100.00% <0.00%> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <0.00%> (ø)
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <0.00%> (ø)
...g/opensearch/sql/data/model/AbstractExprValue.java 100.00% <0.00%> (ø)
...g/opensearch/sql/data/model/ExprDatetimeValue.java 100.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo changed the title Fix ArgumentCaptor can't capture varargs (#1320) [Backport 2.x] Fix ArgumentCaptor can't capture varargs (#1320) Feb 3, 2023
@penghuo penghuo merged commit 3575d0b into opensearch-project:2.x Feb 3, 2023
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants