CLI with SQL plug-in version selection (#35) #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cli with sql version selection Signed-off-by: cnoramut <cnoramut@amazon.com> * update README.md Signed-off-by: cnoramut <cnoramut@amazon.com> * update .gitignore for saved.txt Signed-off-by: cnoramut <cnoramut@amazon.com> * update README.md and default 3.1 sql version Signed-off-by: cnoramut <cnoramut@amazon.com> * update README.md for build.gradle instruction Signed-off-by: cnoramut <cnoramut@amazon.com> * get config settings from previous CLI Signed-off-by: cnoramut <cnoramut@amazon.com> * use opensearchpy like the previous CLI for indices and checking connection Signed-off-by: cnoramut <cnoramut@amazon.com> * update usage.gif Signed-off-by: cnoramut <cnoramut@amazon.com> * update config handling empty string Signed-off-by: cnoramut <cnoramut@amazon.com> * get version from sonatype and dynamically build fat jar Signed-off-by: cnoramut <cnoramut@amazon.com> * http5 for v3+ Signed-off-by: cnoramut <cnoramut@amazon.com> * add http4 for v2 and update build.gradle to pick dependency more dynamically Signed-off-by: cnoramut <cnoramut@amazon.com> * use datasources submodule jar locally Signed-off-by: cnoramut <cnoramut@amazon.com> * update README.md Signed-off-by: cnoramut <cnoramut@amazon.com> * add necessary packages Signed-off-by: cnoramut <cnoramut@amazon.com> * add --local and --remote commands for local jars dev/test Signed-off-by: cnoramut <cnoramut@amazon.com> * add --local and --remote commands for local jars dev/test Signed-off-by: cnoramut <cnoramut@amazon.com> * remove -v in version to avoid confusion Signed-off-by: cnoramut <cnoramut@amazon.com> * allow user to clone to their chosen directory Signed-off-by: cnoramut <cnoramut@amazon.com> * update artifact v3 to v4 Signed-off-by: cnoramut <cnoramut@amazon.com> * update remote to use --branch, default main Signed-off-by: cnoramut <cnoramut@amazon.com> * update dev guide Signed-off-by: cnoramut <cnoramut@amazon.com> * no longer need local datasources jar Signed-off-by: cnoramut <cnoramut@amazon.com> * update rebuild logic Signed-off-by: cnoramut <cnoramut@amazon.com> * will need to fix datasources in maven snapshot Signed-off-by: cnoramut <cnoramut@amazon.com> * not using wrapper for sigv4 interceptors Signed-off-by: cnoramut <cnoramut@amazon.com> * Python 3.8 to 3.9 Signed-off-by: cnoramut <cnoramut@amazon.com> * Python 3.8 to 3.12 Signed-off-by: cnoramut <cnoramut@amazon.com> * add packages Signed-off-by: cnoramut <cnoramut@amazon.com> * fix error handling Signed-off-by: cnoramut <cnoramut@amazon.com> * use logback instead of sysout Signed-off-by: cnoramut <cnoramut@amazon.com> * simplified python Signed-off-by: cnoramut <cnoramut@amazon.com> * refactoring queryexecution and formatter Signed-off-by: cnoramut <cnoramut@amazon.com> * use builder for client and separate functions Signed-off-by: cnoramut <cnoramut@amazon.com> * update gradle for default build Signed-off-by: cnoramut <cnoramut@amazon.com> * parse calcite plain dynamically Signed-off-by: cnoramut <cnoramut@amazon.com> * refactored with dictionary maps Signed-off-by: cnoramut <cnoramut@amazon.com> * create logs dir if doesnt exist Signed-off-by: cnoramut <cnoramut@amazon.com> * fix test fail Signed-off-by: cnoramut <cnoramut@amazon.com> --------- Signed-off-by: cnoramut <cnoramut@amazon.com>
Swiddis
requested review from
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
seankao-az
as code owners
ps48
approved these changes
Sep 5, 2025
|
Need to wait for opensearch-project/sql#4219 before merging |
noCharger
suggested changes
Sep 9, 2025
There was a problem hiding this comment.
@Swiddis I believe this v2 cli depends on the jars from opensearch-project/sql#3734; if the version indicated in the command does not have the corresponding submodules, it will not work; we need to close the gap before releasing it.
There was a problem hiding this comment.
The export PR is merged, right? What's the gap?
There was a problem hiding this comment.
@Swiddis 1. we should not include any submodule 2. the PR only merge to feature branch not minor version
joshuali925
reviewed
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copying the 2.0 CLI to
mainIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.