[Backport 3.2] Update parameter handling of tools #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add parameter extraction utilities for tool inputs - Add utilities for extracting required parameters and JSON input parameters - Apply parameter extraction in AbstractRetrieverTool and RAGTool - Define TOOL_REQUIRED_PARAMS constant for consistent parameter handling Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Standardize parameter handling in all Tool implementations - Update all Tool interface implementations to use extractInputParameters utility Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Update release note Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Declare origin of helper method extractInputParameters Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Remove displaced comment in javadoc Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Fix failed test in AbstractRetrieverToolTests Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Replace copied tool utils to library ones Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> --------- Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> (cherry picked from commit addf057) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
Zhangxunmt,
amitgalitz,
b4sjoo,
dbwiddis,
dhrubo-os,
eirsep,
jackiehanyang,
jngz-es,
joshpalis,
joshuali925,
kaituo,
lezzago,
model-collapse,
ohltyler,
owaiskazi19,
rbhavna,
sbcd90,
xinyual,
ylwu-amzn,
zane-neo and
zhichao-aws
as code owners
zane-neo
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport addf057 from #618.