Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Nov 10, 2025

Description

Add --timeout (-to) as an option to securityadmin.sh

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

Issues Resolved

Related to #5653

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (2b0b41c) to head (b664c5d).

Files with missing lines Patch % Lines
...a/org/opensearch/security/tools/SecurityAdmin.java 50.00% 0 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
- Coverage   73.26%   73.22%   -0.05%     
==========================================
  Files         434      434              
  Lines       26617    26621       +4     
  Branches     3963     3963              
==========================================
- Hits        19501    19493       -8     
- Misses       5219     5231      +12     
  Partials     1897     1897              
Files with missing lines Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 48.75% <50.00%> (+0.24%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


String hostname = "localhost";
int port = 9200;
int timeout = 30;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should 30 s suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants