Deprecate plugins.security.system_indices.indices

[cwperks]

Description

Deprecate plugins.security.system_indices.indices. Since 2.17, Security now expects these indices to be provided by the registry in the core through SystemIndexPlugin.getSystemIndexDescriptors.

This also removes this setting from the demo security configuration.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

Resolves: #5565

Check List

• New functionality includes testing
• New functionality has been documented
• New Roles/Permissions have a corresponding security dashboards plugin PR
• API changes companion pull request created
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.27%. Comparing base (6660542) to head (62ae354).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5775      +/-   ##
==========================================
- Coverage   73.32%   73.27%   -0.06%     
==========================================
  Files         434      434              
  Lines       26524    26522       -2     
  Branches     3948     3948              
==========================================
- Hits        19448    19433      -15     
- Misses       5194     5207      +13     
  Partials     1882     1882              

Files with missing lines	Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java	85.20% <ø> (ø)
...y/tools/democonfig/SecuritySettingsConfigurer.java	71.73% <ø> (-0.31%)	⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shikharj05]

Thanks @cwperks for the change. won't this count as a breaking change for setups that still rely on the YML setting? can we make this change in a 3.x minor version?

[cwperks]

Thanks @cwperks for the change. won't this count as a breaking change for setups that still rely on the YML setting? can we make this change in a 3.x minor version?

It's not breaking. This PR marks it as deprecated which means it can still be used in opensearch.yml

This pr does remove it from the demo security configuration since it is redundant now.