Skip to content

Conversation

@kaituo
Copy link
Contributor

@kaituo kaituo commented Jun 19, 2025

Description

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
Not a backport.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No new permission.

Testing

Manual testing passed.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (48435ac) to head (c3d1e64).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
+ Coverage   72.36%   72.40%   +0.03%     
==========================================
  Files         394      394              
  Lines       24291    24291              
  Branches     3713     3713              
==========================================
+ Hits        17579    17588       +9     
+ Misses       4883     4873      -10     
- Partials     1829     1830       +1     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks
Copy link
Member

cwperks commented Jun 19, 2025

@kaituo please fix the code hygiene error

Signed-off-by: Kaituo Li <kaituo@amazon.com>
@kaituo
Copy link
Contributor Author

kaituo commented Jun 19, 2025

@cwperks fixed permission order.

@cwperks cwperks added skip-changelog backport 3.1 backport to 3.1 branch labels Jun 19, 2025
@DarshitChanpura DarshitChanpura merged commit 827fbec into opensearch-project:main Jun 19, 2025
75 of 77 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 19, 2025
Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 827fbec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.1 backport to 3.1 branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants