-
Couldn't load subscription status.
- Fork 337
Integrate search-relevance functionalities with security plugin #5376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate search-relevance functionalities with security plugin #5376
Conversation
|
@fen-qin can you fix the code hygiene issues? |
|
Let's also add a CHANGELOG entry |
b119fbc to
a469f55
Compare
Hello, Craig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one comment, commas are not needed at the end of actions in the yaml file.
Signed-off-by: Fen Qin <mfenqin@amazon.com>
Thanks, Darshit. resolve this comment |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5376 +/- ##
==========================================
- Coverage 72.13% 72.12% -0.02%
==========================================
Files 382 382
Lines 23697 23697
Branches 3644 3644
==========================================
- Hits 17095 17091 -4
- Misses 4804 4805 +1
- Partials 1798 1801 +3
🚀 New features to boost your workflow:
|
79a663e
into
opensearch-project:main
Description
Adds search-relevance related roles to the plugin:
Adds search-relevance system indices to demo scripts:
.plugins-search-relevance-experiment.plugins-search-relevance-judgment-cacheIssues Resolved
This is a new feature for 3.1 release, no backfort
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.