Skip to content

Conversation

@fen-qin
Copy link
Contributor

@fen-qin fen-qin commented Jun 5, 2025

Description

Adds search-relevance related roles to the plugin:

  • read only
  • full access.

Adds search-relevance system indices to demo scripts:

  • .plugins-search-relevance-experiment
  • .plugins-search-relevance-judgment-cache

Issues Resolved

This is a new feature for 3.1 release, no backfort

Testing

N/A

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@fen-qin fen-qin force-pushed the search-relevance branch from f5301a4 to 7d9ed62 Compare June 6, 2025 01:31
@cwperks
Copy link
Member

cwperks commented Jun 6, 2025

@fen-qin can you fix the code hygiene issues?

@cwperks
Copy link
Member

cwperks commented Jun 6, 2025

Let's also add a CHANGELOG entry

@fen-qin fen-qin force-pushed the search-relevance branch 2 times, most recently from b119fbc to a469f55 Compare June 6, 2025 14:48
@fen-qin
Copy link
Contributor Author

fen-qin commented Jun 6, 2025

Let's also add a CHANGELOG entry

Hello, Craig
I've addressed all comments. put the PR from draft to review. Thank you!

@fen-qin fen-qin marked this pull request as ready for review June 6, 2025 14:49
cwperks
cwperks previously approved these changes Jun 6, 2025
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one comment, commas are not needed at the end of actions in the yaml file.

Signed-off-by: Fen Qin <mfenqin@amazon.com>
@fen-qin
Copy link
Contributor Author

fen-qin commented Jun 6, 2025

only one comment, commas are not needed at the end of actions in the yaml file.

Thanks, Darshit. resolve this comment

DarshitChanpura
DarshitChanpura previously approved these changes Jun 6, 2025
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (228744a) to head (11f2364).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5376      +/-   ##
==========================================
- Coverage   72.13%   72.12%   -0.02%     
==========================================
  Files         382      382              
  Lines       23697    23697              
  Branches     3644     3644              
==========================================
- Hits        17095    17091       -4     
- Misses       4804     4805       +1     
- Partials     1798     1801       +3     
Files with missing lines Coverage Δ
...y/tools/democonfig/SecuritySettingsConfigurer.java 75.15% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura DarshitChanpura merged commit 79a663e into opensearch-project:main Jun 6, 2025
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants