-
Notifications
You must be signed in to change notification settings - Fork 337
Fix compilation issue after Secure gRPC PR (#17796) merged into core #5263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ger() Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Need to pull in changes from #5262 as well to resolve CI failures. Windows bwc issues may be resolved by opensearch-project/OpenSearch#17878 |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5263 +/- ##
==========================================
- Coverage 72.09% 72.07% -0.03%
==========================================
Files 335 336 +1
Lines 22608 22614 +6
Branches 3554 3554
==========================================
- Hits 16299 16298 -1
- Misses 4542 4546 +4
- Partials 1767 1770 +3
🚀 New features to boost your workflow:
|
|
Waiting for updated windows artifacts (https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-beta1-SNAPSHOT/opensearch-min-3.0.0-beta1-SNAPSHOT-windows-x64-latest.zip) that include opensearch-project/OpenSearch#17878 |
…pensearch-project#5263) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Description
This PR fixes a compilation issue after merge of opensearch-project/OpenSearch#17796 which altered the SecureSettingsFactory interface in core.
This PR is not a replacement for #5152. This is a PR in the interim to fix compilation issues, but the actual implementation will be provided in #5152
This PR also contains changes from #5262
Maintenance
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.