Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Apr 10, 2025

Description

This PR fixes a compilation issue after merge of opensearch-project/OpenSearch#17796 which altered the SecureSettingsFactory interface in core.

This PR is not a replacement for #5152. This is a PR in the interim to fix compilation issues, but the actual implementation will be provided in #5152

This PR also contains changes from #5262

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DarshitChanpura and others added 6 commits April 9, 2025 19:42
…ger()

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Fix compilation issue after Security gRPC PR merged into core Fix compilation issue after Secure gRPC PR merged into core Apr 10, 2025
@cwperks cwperks changed the title Fix compilation issue after Secure gRPC PR merged into core Fix compilation issue after Secure gRPC PR (#17796) merged into core Apr 10, 2025
cwperks added 2 commits April 10, 2025 09:30
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
reta
reta previously approved these changes Apr 10, 2025
@cwperks
Copy link
Member Author

cwperks commented Apr 10, 2025

Need to pull in changes from #5262 as well to resolve CI failures.

Windows bwc issues may be resolved by opensearch-project/OpenSearch#17878

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (2313636) to head (c2a5ef4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...y/tools/democonfig/SecuritySettingsConfigurer.java 0.00% 9 Missing ⚠️
...pensearch/security/tools/democonfig/Installer.java 40.00% 6 Missing ⚠️
.../security/tools/democonfig/DefaultExitHandler.java 33.33% 2 Missing ⚠️
...ecurity/tools/democonfig/CertificateGenerator.java 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5263      +/-   ##
==========================================
- Coverage   72.09%   72.07%   -0.03%     
==========================================
  Files         335      336       +1     
  Lines       22608    22614       +6     
  Branches     3554     3554              
==========================================
- Hits        16299    16298       -1     
- Misses       4542     4546       +4     
- Partials     1767     1770       +3     
Files with missing lines Coverage Δ
.../security/ssl/OpenSearchSecureSettingsFactory.java 62.79% <100.00%> (+0.88%) ⬆️
...ecurity/tools/democonfig/CertificateGenerator.java 92.30% <85.71%> (-1.03%) ⬇️
.../security/tools/democonfig/DefaultExitHandler.java 33.33% <33.33%> (ø)
...pensearch/security/tools/democonfig/Installer.java 72.88% <40.00%> (+0.62%) ⬆️
...y/tools/democonfig/SecuritySettingsConfigurer.java 75.15% <0.00%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks
Copy link
Member Author

cwperks commented Apr 10, 2025

@finnegancarroll
Copy link
Contributor

😟
Thank you @cwperks for the quick fix while I follow up on revising #5152!

@cwperks cwperks merged commit 9692eb5 into opensearch-project:main Apr 10, 2025
40 of 41 checks passed
DarshitChanpura added a commit to DarshitChanpura/security that referenced this pull request Apr 21, 2025
…pensearch-project#5263)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Demo installer tests are broken

6 participants